From owner-svn-src-head@FreeBSD.ORG  Wed Feb 15 15:19:41 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4857E106566B;
	Wed, 15 Feb 2012 15:19:41 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail04.syd.optusnet.com.au (mail04.syd.optusnet.com.au
	[211.29.132.185])
	by mx1.freebsd.org (Postfix) with ESMTP id D357B8FC16;
	Wed, 15 Feb 2012 15:19:40 +0000 (UTC)
Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au
	(c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136])
	by mail04.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	q1FFJbQD014979
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 16 Feb 2012 02:19:38 +1100
Date: Thu, 16 Feb 2012 02:19:37 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Gleb Smirnoff <glebius@FreeBSD.org>
In-Reply-To: <201202151426.q1FEQpn7065868@svn.freebsd.org>
Message-ID: <20120216015919.X2940@besplex.bde.org>
References: <201202151426.q1FEQpn7065868@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r231760 - head/sys/netgraph
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Feb 2012 15:19:41 -0000

On Wed, 15 Feb 2012, Gleb Smirnoff wrote:

> Log:
>  style(9): sort includes.
> Modified: head/sys/netgraph/ng_base.c
> ==============================================================================
> --- head/sys/netgraph/ng_base.c	Wed Feb 15 14:23:01 2012	(r231759)
> +++ head/sys/netgraph/ng_base.c	Wed Feb 15 14:26:50 2012	(r231760)
> @@ -43,25 +43,25 @@
>  */
>
> #include <sys/param.h>
> -#include <sys/systm.h>

systm was already sorted.  Like param.h, it defines important macros that
may be needed by other headers.  For example, many headers use KASSERT().
KASSERT() happens to be a macro, so this happens to work if the other
headers only use it in other macros, but this would fail if any of the
other headers started using it in an inline functions.

> #include <sys/ctype.h>
> #include <sys/errno.h>

errno.h is standard pollution in param.h.  Including it directly is a
style bug.  This style bug was not very common.  It was in 7 files
in kern in 4.4BSD-Lite2, 1 in kern in FreeBSD-3 (after I fixed it in
FreeBSD-2), 4 in kern in FreeBSD-4, and 8 in kern in -current.  But
in the top level directory of netgraph, it is in all 49 of 49 .c files
in -current.

> #include <sys/kdb.h>
> #include <sys/kernel.h>
> +#include <sys/kthread.h>
> #include <sys/ktr.h>
> #include <sys/limits.h>
> #include <sys/lock.h>
> #include <sys/malloc.h>
> #include <sys/mbuf.h>
> +#include <sys/proc.h>
> #include <sys/queue.h>

queue.h is nonstandard pollution in many headers.  It has already been
included (guarded) many times before here.  Unfortunately, since it
is nonstandard, this can't be depended on, though many .c files do.

Bruce