From owner-p4-projects@FreeBSD.ORG Tue Feb 5 10:49:02 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B56E516A46D; Tue, 5 Feb 2008 10:49:02 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6242716A469; Tue, 5 Feb 2008 10:49:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 0F89E13C458; Tue, 5 Feb 2008 10:49:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m15AjGdJ031769; Tue, 5 Feb 2008 03:45:16 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 05 Feb 2008 03:45:16 -0700 (MST) Message-Id: <20080205.034516.41658341.imp@bsdimp.com> To: ed@fxq.nl From: Warner Losh In-Reply-To: <20080205073131.GR1179@hoeg.nl> References: <200802040843.m148htF0037992@repoman.freebsd.org> <20080204.134930.-1350498280.imp@bsdimp.com> <20080205073131.GR1179@hoeg.nl> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rrs@FreeBSD.org, perforce@FreeBSD.org Subject: Re: PERFORCE change 134769 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2008 10:49:03 -0000 > * M. Warner Losh wrote: > > I don't think you want this change. it is wrong because we don't > > support ISA_MIPS64's notion of 64-bit registers correctly. > > Just tracking the commits a little; you mean that the MIPS port doesn't > yet support 64 bits registers in the CPU context switching code? I mean that it doesn't support saving 64-bit registers when compiled for 32-bit operation. Just adding ISA_MIPS64 doesn't change the fact that the kernel is built with the o32 abi. Most fo the code to support the change is in place, but hasn't been fleshed out in a few key areas. Warner