From owner-freebsd-ports@FreeBSD.ORG Sat Mar 31 08:44:02 2012 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96326106566B; Sat, 31 Mar 2012 08:44:02 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward10.mail.yandex.net (forward10.mail.yandex.net [IPv6:2a02:6b8:0:202::5]) by mx1.freebsd.org (Postfix) with ESMTP id 015B38FC0A; Sat, 31 Mar 2012 08:44:02 +0000 (UTC) Received: from smtp6.mail.yandex.net (smtp6.mail.yandex.net [77.88.61.56]) by forward10.mail.yandex.net (Yandex) with ESMTP id 98DDC1020240; Sat, 31 Mar 2012 12:44:00 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1333183440; bh=1W09GtU5earToApyr2sSnk5BD2Uam0XEFRadbCjRHQc=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=oDIczx1hqwsdVmoMn07+HF3P4qj4AFIUq4R6G3x2vtHEOE0K2Pi5tec++ozdpO3fv U4t4RBtrsdKPihs6J7FHtsc763b6Y+MRu1+SmSBrk50JRWUBi/ouyFxIMpZdpU0EpF FAKz6jIwja4xBNuRKwzV/yZTfiifZKRXMveYOokQ= Received: from smtp6.mail.yandex.net (localhost [127.0.0.1]) by smtp6.mail.yandex.net (Yandex) with ESMTP id 7B94A1640509; Sat, 31 Mar 2012 12:44:00 +0400 (MSK) Received: from unknown (unknown [178.76.224.133]) by smtp6.mail.yandex.net (nwsmtp/Yandex) with ESMTP id i0Gubde6-i0GuJJii; Sat, 31 Mar 2012 12:44:00 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1333183440; bh=1W09GtU5earToApyr2sSnk5BD2Uam0XEFRadbCjRHQc=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=J03iy0JwAzrr4jnCnkBNiKNa/Zbw5QZ+u6Q7+tgOTI1VaNxvZvLp7+y3a8nHoCiiy K1MSqJcYmun8I/UdN8+Iaf73RGNvp1EQP26OlBROZLevKY6PmOn2VAUZsNB1kAmL8F P6Oyfj70YUAmRINiSn4SnBF7r/TMmTiYMbSewXFE= Message-ID: <4F76C3B7.5010305@yandex.ru> Date: Sat, 31 Mar 2012 12:43:35 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.3) Gecko/20120314 Thunderbird/10.0.3 MIME-Version: 1.0 To: Matthias Andree References: <4F76ABE6.206@FreeBSD.org> In-Reply-To: <4F76ABE6.206@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: ports@FreeBSD.org Subject: Re: rawtherapee 4.0.7 build failure on 9-STABLE amd64 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2012 08:44:02 -0000 Matthias Andree wrote on 31.03.2012 11:01: > Ruslan, > > I cannot build rawtherapee 4.0.7 on 9-STABLE amd64, > re-running it after failure with "make MAKE_JOBS_UNSAFE=yes" yields: [...] > math.h line 239 declares "double log2(double);", so I presume that > patch-rtengine_improcfun.h proves harmful here; the "#ifndef log2(x)" is > bogus if log2 isn't declared as macro (and is actually what breaks the > compile), and the macro is #define log2(x) ((log(x)/log(2)). > > It might be more useful to do this instead: > > static const double lnOf2 = log(2); > static inline double log2(double x) { return log(x)/lnOf2; } > > or possibly checking math.h for log2() before adding the patch. > > I'm afraid I won't have the time to do that now; could you? > > Thanks. > > Best, > Matthias > > Should be fixed now. That was a last minute change when I realize that it doesn't build on 8.2. I didn't rechecked it on 9/10 after the fix was applied. Apologies and thanks for the hands up. Btw, it builds fine to me on -current amd64 with MAKE_JOBS_SAFE=yes, should I add this knob to Makefile? -- Regards, Ruslan Tinderboxing kills... the drives.