From owner-freebsd-bugs@freebsd.org Thu Feb 21 17:18:10 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E4BB14E8736 for ; Thu, 21 Feb 2019 17:18:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F3D1783EA8 for ; Thu, 21 Feb 2019 17:18:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B4EFC14E8734; Thu, 21 Feb 2019 17:18:09 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 926F614E8732 for ; Thu, 21 Feb 2019 17:18:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BA5683EA5 for ; Thu, 21 Feb 2019 17:18:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 5146C1D4B8 for ; Thu, 21 Feb 2019 17:18:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x1LHI84l015321 for ; Thu, 21 Feb 2019 17:18:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x1LHI8ba015318 for bugs@FreeBSD.org; Thu, 21 Feb 2019 17:18:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 235920] ifconfig: unable to create another interface after renaming the previous one with the same name Date: Thu, 21 Feb 2019 17:18:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: olevole@olevole.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 17:18:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235920 Bug ID: 235920 Summary: ifconfig: unable to create another interface after renaming the previous one with the same name Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: olevole@olevole.ru Tested on: 12.0-RELEASE, 13-CURRENT (r344398) When I try to create an interface (via ifconfig), then rename it (via ifcon= fig name) and create another one with the same name, this causes an error. E.g: 1) Create and rename interface:=20 ifconfig tap100 create name xxx or: ifconfig tap100 create && ifconfig tap100 name xxx 2) check that the interface original interface is missing now: ifconfig tap100 ifconfig: interface tap100 does not exist 3) great! we can create another one: ifconfig tap100 create ifconfig: SIOCIFCREATE2: File exists As far as I can see, the problem is in the UNR(9) area (alloc_unr_specific) The path to the error that I see: a) src/sbin/ifconfig/ifconfig.c: setifname() ->=20 ... if (ioctl(s, SIOCSIFNAME, (caddr_t)&ifr) < 0) { free(newname); err(1, "ioctl SIOCSIFNAME (set name)"); } ... b) src/sys/net/if.c: ifioctl() -> ... case SIOCIFCREATE: case SIOCIFCREATE2: error =3D priv_check(td, PRIV_NET_IFCREATE); if (error =3D=3D 0) error =3D if_clone_create(ifr->ifr_name, sizeof(ifr->ifr_name), cmd =3D=3D SIOCIFCREATE2= ? ifr_data_get_ptr(ifr) : NULL); goto out_noref; ... c) src/sys/net/if_clone.c: if_clone_create() -> .. return (if_clone_createif(ifc, name, len, params)); .. d) src/sys/net/if_clone.c: if_clone_createif() -> .. err =3D ifc_simple_create(ifc, name, len, params); .. e) src/sys/net/if_clone.c: ifc_simple_create() -> .. err =3D ifc_alloc_unit(ifc, &unit); .. f) src/sys/net/if_clone.c: ifc_alloc_unit() -> .. if (alloc_unr_specific(ifc->ifc_unrhdr, *unit) =3D=3D -1) { return (EEXIST); } .. If we create an interface for the first time, this function ends with: IF_CLONE_ADDREF(ifc); When we create an interface a second time, we get: return (EEXIST); --=20 You are receiving this mail because: You are the assignee for the bug.=