From owner-freebsd-current@FreeBSD.ORG Wed Jun 15 03:49:42 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 18FC716A41C for ; Wed, 15 Jun 2005 03:49:42 +0000 (GMT) (envelope-from emaste@phaedrus.sandvine.ca) Received: from mailserver.sandvine.com (sandvine.com [199.243.201.138]) by mx1.FreeBSD.org (Postfix) with ESMTP id B9D9843D49 for ; Wed, 15 Jun 2005 03:49:41 +0000 (GMT) (envelope-from emaste@phaedrus.sandvine.ca) Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by mailserver.sandvine.com with Microsoft SMTPSVC(5.0.2195.6713); Tue, 14 Jun 2005 23:49:40 -0400 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 12627) id CA9EE13614; Tue, 14 Jun 2005 23:49:40 -0400 (EDT) Date: Tue, 14 Jun 2005 23:49:40 -0400 From: Ed Maste To: Doug White Message-ID: <20050615034940.GB84053@sandvine.com> References: <20050613192308.GA87640@sandvine.com> <20050613130317.G2682@carver.gumbysoft.com> <20050613205052.GA91486@sandvine.com> <20050614191338.N24745@carver.gumbysoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050614191338.N24745@carver.gumbysoft.com> User-Agent: Mutt/1.4.2.1i X-OriginalArrivalTime: 15 Jun 2005 03:49:41.0007 (UTC) FILETIME=[426A09F0:01C5715D] Cc: freebsd-current@freebsd.org Subject: Re: savecore(8) increments /var/crash/bounds on each boot X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2005 03:49:42 -0000 On Tue, Jun 14, 2005 at 07:24:24PM -0700, Doug White wrote: > On Mon, 13 Jun 2005, Ed Maste wrote: > > > On Mon, Jun 13, 2005 at 01:03:50PM -0700, Doug White wrote: > > > > > On Mon, 13 Jun 2005, Ed Maste wrote: > > > > > > > I notice that as of sbin/savecore/savecore.c 1.72 and in 5.4-RELEASE > > > > savecore increments the number in /var/crash/bounds on each boot, > > > > regardless of whether it rebooted due to panic or was a clean shutdown. > > > > > > > > Is this the desired behaviour or an unintentional side effect? > > > > We've been monitoring the value in bounds to detect panics, which > > > > of course doesn't work anymore. > > > > > > Its certainly not the historical behavior :-) > > > > > > Think you could submit a patch with the fix? > > > > The attached patch does the trick. In -vv mode the bounds used to > > be included with the first/last dump header output -- I just replaced > > it with -1. > > I don't see how this works. It should generate a bunch of > use-uninitialized warning since bounds is used in a sprintf at line 376, > in DoFile(): > > 376: sprintf(buf, "info.%d", bounds); The patch I posted puts the getbounds() call back in the original location, which is just before this sprintf -- no uninitialized use. > plus additional sprintf's down the file, since the value of bounds is only > set by that getbounds() call. The correct fix is to put a > > else > goto done; I don't see how that helps -- if bounds already contains a valid number (the normal case) it will then skip over writing the new (incremented) value back to the bounds file. Won't all cores get written to the same file then? -- Ed Maste, Sandvine Incorporated