Date: Mon, 31 Jul 2017 09:31:47 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: koobs@FreeBSD.org, Baptiste Daroussin <bapt@FreeBSD.org>, araujo@freebsd.org Cc: Adam Weinberger <adamw@adamw.org>, ports-committers <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, FreeBSD Python Team <freebsd-python@freebsd.org>, "portmgr@FreeBSD.org" <portmgr@FreeBSD.org> Subject: Re: svn commit: r446864 - head/sysutils/py3-iocage Message-ID: <4d60e32b-ff90-1200-d614-957c3ce0276f@FreeBSD.org> In-Reply-To: <e255b7da-f9e9-370d-3183-5538ca9e35c2@FreeBSD.org> References: <201707290417.v6T4HWGX048404@repo.freebsd.org> <98CDBA25-758F-4C2E-9A25-426B9DEEACBF@adamw.org> <CAOfEmZjCUYDfb%2B_6okRCbyTeSLgLWLaXF0V9jF%2Bn=h1g2vS_Lg@mail.gmail.com> <22e402da-53de-3418-e3d9-9777cd35f778@FreeBSD.org> <CAOfEmZiOY3ej9N0jwFqdOOXWYdNpnMqmLuzXN%2BScHz9zhr=gJw@mail.gmail.com> <20170731100728.frov3ttvs3qyxsm7@ivaldir.net> <0dd92f7f-5f3e-19df-acb8-c1d74f7c4d92@FreeBSD.org> <e255b7da-f9e9-370d-3183-5538ca9e35c2@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QQhkXDEhjGCbcONbPNXUPHl4cIKNpI1bA Content-Type: multipart/mixed; boundary="OjFgkJgGcbs6lXnSGijE1CwQpAktJoSuN"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: koobs@FreeBSD.org, Baptiste Daroussin <bapt@FreeBSD.org>, araujo@freebsd.org Cc: Adam Weinberger <adamw@adamw.org>, ports-committers <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, FreeBSD Python Team <freebsd-python@freebsd.org>, "portmgr@FreeBSD.org" <portmgr@FreeBSD.org> Message-ID: <4d60e32b-ff90-1200-d614-957c3ce0276f@FreeBSD.org> Subject: Re: svn commit: r446864 - head/sysutils/py3-iocage References: <201707290417.v6T4HWGX048404@repo.freebsd.org> <98CDBA25-758F-4C2E-9A25-426B9DEEACBF@adamw.org> <CAOfEmZjCUYDfb+_6okRCbyTeSLgLWLaXF0V9jF+n=h1g2vS_Lg@mail.gmail.com> <22e402da-53de-3418-e3d9-9777cd35f778@FreeBSD.org> <CAOfEmZiOY3ej9N0jwFqdOOXWYdNpnMqmLuzXN+ScHz9zhr=gJw@mail.gmail.com> <20170731100728.frov3ttvs3qyxsm7@ivaldir.net> <0dd92f7f-5f3e-19df-acb8-c1d74f7c4d92@FreeBSD.org> <e255b7da-f9e9-370d-3183-5538ca9e35c2@FreeBSD.org> In-Reply-To: <e255b7da-f9e9-370d-3183-5538ca9e35c2@FreeBSD.org> --OjFgkJgGcbs6lXnSGijE1CwQpAktJoSuN Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/31/2017 9:26 AM, Bryan Drewery wrote: > On 7/31/2017 3:28 AM, Kubilay Kocak wrote: >> On 7/31/17 8:07 PM, Baptiste Daroussin wrote: >>> On Mon, Jul 31, 2017 at 05:03:35PM +0800, Marcelo Araujo wrote: >>>> 2017-07-31 10:35 GMT+08:00 Kubilay Kocak <koobs@freebsd.org>: >>>> >>>>> On 7/31/17 11:16 AM, Marcelo Araujo wrote: >>>>>> >>>>>> >>>>>> 2017-07-30 21:18 GMT+08:00 Adam Weinberger <adamw@adamw.org >>>>>> <mailto:adamw@adamw.org>>: >>>>>> >>>>>> > On 28 Jul, 2017, at 22:17, Marcelo Araujo <araujo@freebsd.or= g >>>>>> <mailto:araujo@freebsd.org>> wrote: >>>>>> > >>>>>> > Author: araujo >>>>>> > Date: Sat Jul 29 04:17:31 2017 >>>>>> > New Revision: 446864 >>>>>> > URL: https://svnweb.freebsd.org/changeset/ports/446864 >>>>>> <https://svnweb.freebsd.org/changeset/ports/446864>; >>>>>> > >>>>>> > Log: >>>>>> > - Update to 0.9.9. >>>>>> > >>>>>> > Changelog at: https://github.com/iocage/iocage/releases/tag= /0.9.9 >>>>>> <https://github.com/iocage/iocage/releases/tag/0.9.9>; >>>>>> > >>>>>> > Modified: >>>>>> > head/sysutils/py3-iocage/Makefile >>>>>> > head/sysutils/py3-iocage/distinfo >>>>>> > >>>>>> > Modified: head/sysutils/py3-iocage/Makefile >>>>>> > >>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>>>> > --- head/sysutils/py3-iocage/Makefile Sat Jul 29 04:00:56 20= 17 >>>>>> (r446863) >>>>>> > +++ head/sysutils/py3-iocage/Makefile Sat Jul 29 04:17:31 20= 17 >>>>>> (r446864) >>>>>> > @@ -1,7 +1,7 @@ >>>>>> > # $FreeBSD$ >>>>>> > >>>>>> > PORTNAME=3D iocage >>>>>> > -PORTVERSION=3D 0.9.8.1 >>>>>> > +PORTVERSION=3D 0.9.9 >>>>>> > CATEGORIES=3D sysutils python >>>>>> > PKGNAMEPREFIX=3D ${PYTHON_PKGNAMEPREFIX} >>>>>> > >>>>>> > @@ -15,6 +15,7 @@ BUILD_DEPENDS=3D >>>>>> ${PYTHON_PKGNAMEPREFIX}pytest-runner>=3D2 >>>>>> > RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}click>=3D6.7:devel/py= 3-click \ >>>>>> > ${PYTHON_PKGNAMEPREFIX}tqdm>=3D4.10.0:misc/py3= -tqdm \ >>>>>> > >>>>>> ${PYTHON_PKGNAMEPREFIX}coloredlogs>0:devel/py3-coloredlogs \ >>>>>> > + >>>>>> ${PYTHON_PKGNAMEPREFIX}verboselogs>0:devel/py-verboselogs \ >>>>>> > ca_root_nss>0:security/ca_root_nss \ >>>>>> > >>>>>> ${PYTHON_PKGNAMEPREFIX}texttable>=3D0.8.7:textproc/py3-textta= ble \ >>>>>> > >>>>>> ${PYTHON_PKGNAMEPREFIX}pytest-runner>=3D2.0.0:devel/py3-pytes= t-runner >>>>>> >>>>>> Hi Marcelo, >>>>>> >>>>>> There is no py36-verboselogs package. You'll need to create a >>>>>> py3-verboselogs port, because right now only py27-verboselogs = gets >>>>>> built. >>>>>> >>>>>> See the build failure at >>>>>> http://beefy10.nyi.freebsd.org/data/110i386-default/ >>>>> 446906/logs/py36-iocage-0.9.9.log >>>>>> <http://beefy10.nyi.freebsd.org/data/110i386-default/ >>>>> 446906/logs/py36-iocage-0.9.9.log> >>>>>> >>>>>> # Adam >>>>>> >>>>>> >>>>>> -- >>>>>> Adam Weinberger >>>>>> adamw@adamw.org <mailto:adamw@adamw.org> >>>>>> https://www.adamw.org >>>>>> >>>>>> >>>>>> Hi, >>>>>> >>>>>> We can't add py3 ports because soon we gonna have FLAVORS! >>>>>> I can build iocage if I define the python version on my make.conf,= >>>>>> however I can see the issue with poudriere. >>>>> >>>>> Since this port already uses py3-* (workaround) ports for dependenc= ies >>>>> and there is no known ETA for VARIANTS support in ports, and the po= rt is >>>>> broken without py3-verboselogs, it should be created. >>>>> >>>>> Also, py-iocage should be resurrected, py-iocage was incorrectly de= leted >>>>> [1] instead of this one when it moved to Python 3.x only support. p= y3-* >>>>> ports are only for (temporary) dependencies >>>>> >>>>> [1] http://svnweb.freebsd.org/changeset/ports/445459 >>>> >>>> >>>> How I can pass the pre-commit hook that blocks any add of py3 slave = ports? >>>> >>>> Best, >>>> >>> >>> FLAVORS are in review and finished, poudriere is able to deal with th= em -devel. >>> >>> The commit is pending exp-run, documentation etc. It takes time as it= is a major >>> change in the framework with huge impact. >>> >>> py3-* were a hack in the first place that should never have been done= , they >>> addition made it more complicated to work on FLAVORS, adding more and= by passing >>> the hook would just give even more delay for FLAVORS to be committed.= >> >>> Best regards, >>> Bapt >>> >> >> Existing ports (particularly popular ports like iocage) that already >> rely on these dependencies should be allowed continue to work. The blo= ck >> relies on the assumption that new dependencies for existing and workin= g >> ports will never be needed, which is the case here. >> >> The block on new py3-* ports (while noone likes them) was and is >> premature, and is even more so without an alternative, and it was >> heavy-handed. Developers were already trying hard to minimise their us= e. >> >> The block should be removed, and can be re-added when the official >> package builders are running with the poudriere "special feature" >> version that builds py3-* versions of py- ports automatically, or port= s >=20 > I'm not quite awake yet so pardon the terseness. I will start a > poudriere-devel exp-run now and then push it out to the builders > following that in the next 2 days. That will allow py3- dependencies t= o > build properly. It would allow existing py3- leaf ports to build as we= ll. >=20 > As for py3- leaf ports I would allow them but they have to follow stric= t > criteria: > - They must be named category/py3-foo > - They must be a *slave* port to a category/py-foo > - They must be supported on all python versions, not just 3.4+ or > something odd like that. >=20 > The FLAVORS support in Poudriere is done. What is held up is an exp-run= > that I'm tasked with and various bugs/documentation/more exp-runs. > Every new py3- port added that doesn't follow those rules means we have= > to change Poudriere again. I think the criteria above is reasonable bu= t > I know the last one is problematic. >=20 > I've said on IRC before but not sure I have here, that py3- ports beyon= d > the fixed cases above, are only useful for generating a leaf package fo= r > users to download. They can still build category/py-foo as PYTHON3 > today though. So there is an alternative but it is just not > package-friendly yet. Also this is only true for 'bulk -a'. If a user is using 'bulk cat/foo1 cat/foo2 cat/foo3' then they don't need the py3- stuff at all with poudriere-devel. - Use python default version =3D 2 - Add fake py3 ports into bulk list: devel/py3-foo (so long as devel/py-foo exists then py3-foo will work, even py33-foo py34-foo, etc) >=20 > About the block being premature, I will agree that what was lacking was= > a communication about it to a wider community and an override allowed > with Portmgr review. At the time I wasn't quite sure what the criteria= > for an override would even be. Now that I understand it more and have > Poudriere being a bit smarter than my first implementation, I will twea= k > the block to allow a Portmgr override. >=20 >> variants supports lands, whichever one comes first. If that's in 3 day= s, >> great, if its in 3 weeks or 2 months, our developers have been allowed= >> to keep the status quo working. >> >> Users are currently being impacted where there is no alternative and >> they should not be asked to pay that price for our dislike of py3-* po= rts. >> >> Best regards, >> Koobs >> >=20 >=20 --=20 Regards, Bryan Drewery --OjFgkJgGcbs6lXnSGijE1CwQpAktJoSuN-- --QQhkXDEhjGCbcONbPNXUPHl4cIKNpI1bA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZf1t0AAoJEDXXcbtuRpfPs2gIAJbuz40ZlMTl6qmb1VaHITbb KgWoS+sfaqbFpKDjGjPM4/psEmz1YTweOZwa3b5dQMt3abTQr9Im3NAkX8CYuQ47 q2VNK4GJBagZaJ1X6MSZaTC+eRunu6HtTcCho/HqKnUT5BunULeHwBIB9kW6mIR5 /ppJKz9tOYbTaPhgUVLV/eb/tZ/iXAtLbhl2fCuijbTKMclfqBvUg+zsi/kBgeR8 daC9fx/L/Ni+zRjMlRwhk7lEv8xFp6R+1zhWzyIbbWuluHCpkGo4RcfEN/HRg5VN 7POdX2z3EKTw++4Evum2kp/QYkcuIuPpC0tR0+WV3SQvRw5hR5BM3tPgv+FV4tQ= =AEil -----END PGP SIGNATURE----- --QQhkXDEhjGCbcONbPNXUPHl4cIKNpI1bA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4d60e32b-ff90-1200-d614-957c3ce0276f>