From owner-freebsd-net@FreeBSD.ORG Fri May 9 17:55:24 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 953BC10656CA; Fri, 9 May 2008 17:55:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 79DAA8FC16; Fri, 9 May 2008 17:55:24 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unknown [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id E93B81A4D80; Fri, 9 May 2008 10:55:23 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m49Ht2sf016548; Fri, 9 May 2008 13:55:09 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Andre Oppermann Date: Fri, 9 May 2008 12:07:05 -0400 User-Agent: KMail/1.9.7 References: <200805081625.33093.jhb@FreeBSD.org> <48237F1A.6020601@freebsd.org> In-Reply-To: <48237F1A.6020601@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805091207.05611.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 09 May 2008 13:55:09 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7081/Fri May 9 11:52:50 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-net@freebsd.org Subject: Re: Small patch.. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2008 17:55:24 -0000 On Thursday 08 May 2008 06:30:50 pm Andre Oppermann wrote: > John Baldwin wrote: > > At work all the log(LOG_DEBUG, ...) statements in the TCP code in 7.x are > > spamming the heck out of our dmesg so I am #if 0'ing all of them out and > > while doing so ran into this case. Specifically, it doesn't actually bump > > sysctl net.inet.tcp.log_debug=0 is simpler than #if 0 and has the same effect. > In RELENG_7 it was disabled by default. That doesn't shut up log(LOG_DEBUG). That is controlled by syslog settings. Trust me. We enable more crap in syslog at work which is why we were inundated. net.inet.tcp.log_debug was already 0. -- John Baldwin