From owner-cvs-src@FreeBSD.ORG Sun Jul 6 16:17:24 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F3A437B401; Sun, 6 Jul 2003 16:17:24 -0700 (PDT) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 749A843FDF; Sun, 6 Jul 2003 16:17:23 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h66NHL0X003418; Sun, 6 Jul 2003 19:17:22 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200307061244.h66CiBqg079835@repoman.freebsd.org> References: <200307061244.h66CiBqg079835@repoman.freebsd.org> Date: Sun, 6 Jul 2003 19:17:20 -0400 To: Philippe Charnier , src-committers@FreeBSD.org, cvs-src@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: unclaimed-spam X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/usr.sbin/lpr/lpd lpd.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jul 2003 23:17:24 -0000 At 5:44 AM -0700 7/6/03, Philippe Charnier wrote: >charnier 2003/07/06 05:44:11 PDT > > FreeBSD src repository > > Modified files: > usr.sbin/lpr/lpd lpd.c > [...etc...] > Log: > add FBSDID Speaking only for lpd, I wish you would not have added FBSDID. I had started to add FBSDID to all the source files of lpr & friends, and found that it was just annoying when I then went to build lpr on other platforms. So, I switched back to just plain 'rcsid[] ='. It also seems odd to me that you added it to only one source file out of the dozens in usr.sbin/lpr. Is there some reason that this one file stood out as needing FBSDID? -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu