From owner-svn-src-head@FreeBSD.ORG Tue Nov 20 15:48:41 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A52BA483 for ; Tue, 20 Nov 2012 15:48:41 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1350C8FC08 for ; Tue, 20 Nov 2012 15:48:40 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so3207545lbb.13 for ; Tue, 20 Nov 2012 07:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=vKGbtbr7BNVB457VfAUjAJFsjqJLV69DcD9gBdygb80=; b=NzcbMDPOVwdqL/kZTWlWhSwWSobBWQNBeoVYlrDaRF2286ZaLMyUw3PfC93RHuq6km EkQUeDM2SGtGDDjKbe+DcfVUrHNi1g0oetl8zyMkYu0ZDKwcn9pwA4b1BlHEN592P9oT xoJHm+wwPWz0cis/iThViZYQ6nGZEqNo+Cg8s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=vKGbtbr7BNVB457VfAUjAJFsjqJLV69DcD9gBdygb80=; b=pCS6rBcr/1Q0E3+54ikwxdeapjbEA+0AH14fHGGM472X3lDhgShK2n1Nd/0mMzTDcn bn3Ef0xKtjQ8HJmHel/RkWSNt+iUxhj0KUaaD/sgB8eZ6R84IHT0atO5A1ihffeJDPhx JZ4AQIVWK1e081iPgemQZLiEQq2Ap0zl24KGxNThGxGgN7ReCRVYSopJ/kr/ImBKmC2z /gcbwcHO5SLynMhYseREutnrAkza63fqcCtpswljXJUViQLm5T6aQX+Or5kNVnTUDG+D M4pHfbJ91e3A1bLfmRdsmAurhv2th/gow/arTSFMROKKmRR8ZofPpMC/tkZEK6U0Swuu VvEw== Received: by 10.152.102.234 with SMTP id fr10mr15178345lab.28.1353426519569; Tue, 20 Nov 2012 07:48:39 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.166 with HTTP; Tue, 20 Nov 2012 07:48:09 -0800 (PST) In-Reply-To: <20121120172226.R1115@besplex.bde.org> References: <201211200212.qAK2C1sT097754@svn.freebsd.org> <20121120172226.R1115@besplex.bde.org> From: Eitan Adler Date: Tue, 20 Nov 2012 10:48:09 -0500 X-Google-Sender-Auth: RiY8xUCfbdR2NihlOtYGkGyHQCk Message-ID: Subject: Re: svn commit: r243321 - head/usr.sbin/edquota To: Bruce Evans Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnOQm8W/bVM1MWzTXHPWdlOjLWbdsE/JhfFIP5/hnKZn30h5CCq+iO1TFHPVqSJLe31iYPL Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2012 15:48:41 -0000 On 20 November 2012 02:03, Bruce Evans wrote: > On Tue, 20 Nov 2012, Eitan Adler wrote: > >> Log: >> Remove unneeded includes. >> >> Tested with "make universe"; there are no conditional features. > > > "make universe" can't find such features. Except inversely -- when it > doesn't find them, it usually means that there is a bug in the headers. [ thanks for the info. I'll go through it and parse it fully soon ] Just to explain. The above sentence means "I tested this with make universe" AND I checked to make sure that there were no #ifdefs or the like which might rely on these headers. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams