From owner-freebsd-net@FreeBSD.ORG Tue Dec 26 05:40:42 2006 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3F3A516A403 for ; Tue, 26 Dec 2006 05:40:42 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outT.internet-mail-service.net (outT.internet-mail-service.net [216.240.47.243]) by mx1.freebsd.org (Postfix) with ESMTP id 2029213C481 for ; Tue, 26 Dec 2006 05:40:42 +0000 (UTC) (envelope-from julian@elischer.org) Received: from shell.idiom.com (HELO idiom.com) (216.240.47.20) by out.internet-mail-service.net (qpsmtpd/0.32) with ESMTP; Mon, 25 Dec 2006 21:24:02 -0800 Received: from [192.168.2.4] (home.elischer.org [216.240.48.38]) by idiom.com (8.12.11/8.12.11) with ESMTP id kBQ5ebnu007534; Mon, 25 Dec 2006 21:40:38 -0800 (PST) (envelope-from julian@elischer.org) Message-ID: <4590B5D5.6080009@elischer.org> Date: Mon, 25 Dec 2006 21:40:37 -0800 From: Julian Elischer User-Agent: Thunderbird 1.5.0.9 (Macintosh/20061207) MIME-Version: 1.0 To: Max Laier References: <457DCD47.5090004@elischer.org> <20061224093951.GD49045@comp.chem.msu.su> <459032EA.1030601@elischer.org> <200612252239.59737.max@love2party.net> In-Reply-To: <200612252239.59737.max@love2party.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Yar Tikhiy , Andre Oppermann , freebsd-net@freebsd.org Subject: Re: [was] addition to ipfw (read vlans from bridge).. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2006 05:40:42 -0000 Max Laier wrote: > > I'm not sure if you are mistaking Yar for me here. As for my concerns - > consider them withdrawn. I still don't like the idea that the code in > net*inet*/ip_fw2.c gets to know about VLAN internals, but if everybody > feels that it does belong there - fine. I hereby resign from this > thread. > In the latest patch it doesn't.. The only knowledge of vlans is added to if_bridge.c and bridge.c (in 6.x) > Anyway, I hope everybody is having happy holidays. not bad.. > >> If what you are suggesting is that we pass into ipfw an 'offset' >> into the packet as well as the packet, then yes I like that idea, >> but I didn't see Andre suggest it. >> >> I can however submit another patch that does that.. >> >> However I'd like to hear from you a response to the mail >> I sent you with a pure cleanup patch that removes mopst occurrances >> of mtod() from ipfw.. if you did not get that email I can resend it >> to you. you are right max.. I sent the email to you not Yar.. it was just a cleanup patch. >> >>> There is also work in progress to introduce nested VLANs AKA Q-n-Q. >>> They seem to present a challenge to the scheme you are implementing. >> not a permanent problem.. it could be modified to handle it. >> but I'll take it into account in the next version if >> you think it is a required feature.. what is the maximum >> nesting level? >