Date: Mon, 08 Sep 1997 07:34:19 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Steve Passe <smp@csn.net> Cc: smp@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-CVSROOT@freebsd.org Subject: Re: machine/up.h Message-ID: <11169.873696859@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 07 Sep 1997 14:37:40 MDT." <199709072037.OAA27121@Ilsa.StevesCafe.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Why not simply have the code do a #include <machine/smp.h> and in that file have #ifdef SMP #define THIS_STUFF (lkjsdfgskdj) #define THAT_STUFF (lkjsdfgskdj) #else /* !SMP */ #define THIS_STUFF /* Nothing */ #define THAT_STUFF /* Nothing */ #endif In message <199709072037.OAA27121@Ilsa.StevesCafe.com>, Steve Passe writes: >Hi, > >I propose that we create an alternate file to smp.h named up.h. > >code could then look like: > >#ifdef SMP >#include <machine/smp.h> >#else >#include <machine/up.h> >#endif > >I could then move stuff like: > >#ifndef SMP >#define THIS_LOCK /* nop this out for UP */ >#define THAT_FEATURE /* nop this out for UP */ >#endif > >from individual files and gather them all up into up.h This should cause less >disturbance to the source tree than the current methods. > >Any objections? > > >-- >Steve Passe | powered by >smp@csn.net | Symmetric MultiProcessor FreeBSD > > -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11169.873696859>