From owner-svn-src-head@FreeBSD.ORG  Sun Oct 12 19:23:02 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8D6321065690;
	Sun, 12 Oct 2008 19:23:02 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 7CFE98FC19;
	Sun, 12 Oct 2008 19:23:02 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id m9CJN27j053445;
	Sun, 12 Oct 2008 19:23:02 GMT (envelope-from rwatson@svn.freebsd.org)
Received: (from rwatson@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id m9CJN2F0053444;
	Sun, 12 Oct 2008 19:23:02 GMT (envelope-from rwatson@svn.freebsd.org)
Message-Id: <200810121923.m9CJN2F0053444@svn.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Sun, 12 Oct 2008 19:23:02 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r183806 - head/sys/fs/portalfs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Oct 2008 19:23:02 -0000

Author: rwatson
Date: Sun Oct 12 19:23:02 2008
New Revision: 183806
URL: http://svn.freebsd.org/changeset/base/183806

Log:
  The locking in portalfs's socket connect code is no less correct than
  identical code in connect(2), so remove XXX that it might be incorrect.
  
  MFC after:	3 days

Modified:
  head/sys/fs/portalfs/portal_vnops.c

Modified: head/sys/fs/portalfs/portal_vnops.c
==============================================================================
--- head/sys/fs/portalfs/portal_vnops.c	Sun Oct 12 19:19:26 2008	(r183805)
+++ head/sys/fs/portalfs/portal_vnops.c	Sun Oct 12 19:23:02 2008	(r183806)
@@ -279,7 +279,6 @@ portal_open(ap)
 	 * will happen if the server dies.  Sleep for 5 second intervals
 	 * and keep polling the reference count.   XXX.
 	 */
-	/* XXXRW: Locking? */
 	SOCK_LOCK(so);
 	while ((so->so_state & SS_ISCONNECTING) && so->so_error == 0) {
 		if (fmp->pm_server->f_count == 1) {