From owner-freebsd-current@FreeBSD.ORG Mon Jan 5 06:58:32 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3787216A4CE for ; Mon, 5 Jan 2004 06:58:32 -0800 (PST) Received: from wbm2.pair.net (wbm2.pair.net [209.68.3.43]) by mx1.FreeBSD.org (Postfix) with SMTP id 936B243D45 for ; Mon, 5 Jan 2004 06:58:29 -0800 (PST) (envelope-from silby@silby.com) Received: (qmail 39673 invoked by uid 65534); 5 Jan 2004 14:58:28 -0000 Received: from 158.6.15.27 ([158.6.15.27]) (SquirrelMail authenticated user silby@silby.com) by webmail.pair.com with HTTP; Mon, 5 Jan 2004 09:58:28 -0500 (EST) Message-ID: <53342.158.6.15.27.1073314708.squirrel@webmail.pair.com> Date: Mon, 5 Jan 2004 09:58:28 -0500 (EST) From: To: X-pair-Authenticated: 158.6.15.27 In-Reply-To: <200401042151.i04Lp27E009737@gw.catspoiler.org> References: <200401041115.29188.dejan.lesjak@ijs.si> <200401042151.i04Lp27E009737@gw.catspoiler.org> X-Priority: 3 Importance: Normal X-Mailer: SquirrelMail (version 1.2.11) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 06 Jan 2004 05:22:19 -0800 cc: dejan.lesjak@ijs.si cc: freebsd-current@FreeBSD.org cc: wpaul@FreeBSD.org cc: ryans@gamersimpact.com Subject: Re: 5.2-RC oerrs and collisions on dc0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2004 14:58:32 -0000 > I just took a closer look at the busdma diff, and this change to > dc_txeof() looks very suspicious: > > - if (!(cur_tx->dc_ctl & DC_TXCTL_LASTFRAG) || > + if (!(cur_tx->dc_ctl & DC_TXCTL_FIRSTFRAG) || > cur_tx->dc_ctl & DC_TXCTL_SETUP) { I'm current checking e-mail via a webmail interface and I haven't had time to check over your later posts, but I thought I'd note that the change above _is_ busdma related; one subtle change in the busdma code was that the mbuf is now linked to the first fragment in the chain, whereas before it was linked to the last fragment. So, the change does make sense on the surface, although I wouldn't be surprised if it broke something subtle. Mike "Silby" Silbersack