From nobody Tue Nov 26 12:40:29 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XyMcG0vDSz5fQ5X for ; Tue, 26 Nov 2024 12:40:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XyMcF6bdLz49pL for ; Tue, 26 Nov 2024 12:40:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732624829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfeEoFbt1fYVGHwutIXz038rk0cSQHx96XzFx9thMSk=; b=gXy1x2LTlD+4qNs1f2GD0/jYHfI4tLoO3CTjFXirGgiKUlg8F66SSa6awoNyvOCsSC6ChU B3bLk0LZF7g0WTR/HknxoK4s//XoOkrbMcPmOoi9P411oPQh3lEPwb8vQ7ThK6BcOgnJsz pwJlxLkwvLA9mJ+6Jq7xtt5c5k05YnCfXKx41fkySlrTwHRf82vPOzL24Zmedfv45UrAc2 Vp1NZUapjeN+/pNE4ZWPVDHB8p7BMFNHHFHVRzjKJ3m/Z4VE+3Byg3I9pG2ItbWjbUTjme rVAyiVqC9g69O5Uwj3XmPQsU8iPKjXj5yRdvyxHpgvtxim0nx/m1oC66oiDdZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732624829; a=rsa-sha256; cv=none; b=HcXguFLBJ+Q2WxOTOx2Ut+t62z/WAwfmJhhBwtW+0KkWuC3dG1MrUiFNVai0mbS+3W7HXd c7Wuq+KqTb5uyMaqQaEg9+IBxJ7+Ie7AjpZK3FTq00Vx8+WLkkQvc9HUbvVHwslL4Fd53N BgyVQ6bRY+pYUADBzPkJ+eALVi9/fOZnTE0NqWTDvNMx/FLfhfld2/SP7zrJ1O0Zh2Jlts mYO0JYX5LKb3/NbWz/q6rmlOWZsWkUbvgBJtgBSAF3nKcM+a70zrsGR43oMHcXNBGqjiYD C01wUBxztp/MR8HraQSu55CUhCE2E/ZN0hLakQ87Pgha3P9fyUsbx+dQLvRzyg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XyMcF6539zPpl for ; Tue, 26 Nov 2024 12:40:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4AQCeTqT016153 for ; Tue, 26 Nov 2024 12:40:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4AQCeTZQ016152 for bugs@FreeBSD.org; Tue, 26 Nov 2024 12:40:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 282984] [PATCH] pfctl: add -T `makezero` to touch pfras_tzero _only_ for non-zero entries Date: Tue, 26 Nov 2024 12:40:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: leon+freebsd@darkk.net.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282984 --- Comment #2 from Leonid Evdokimov --- (In reply to Kristof Provost from comment #1) I also dislike the name, but I failed to come up with a better one. I'd appreciate help here. "touch" is a bad one as it actually changes counters. "clear" sounds like an option, but might be confused with "flush", so IMO i= t's even worse than "makezero". "mark" might come from mark-n-sweep gc, but it's confusing in this context. "rearm" comes with watchdog/timer semantics that is kinda close, but still = not 100% applicable. "reset" is almost the winner, but TCP has already taken the word for RST. I would say "reset" is my 2nd preferred option after "makezero". So I'm kinda out of reasonable options. > come with some performance penalty It's probably my mistake made under assumption that counter-aware tables ha= ve different memory layout and handling. I was unaware of pfr_get_astats() saying that > It was possible to have a table without per-entry counters. Now they are= =20 > always allocated, we just discard data when reading it if table is not=20 > configured to have counters. ACK for tests & commit message. Will do. --=20 You are receiving this mail because: You are the assignee for the bug.=