From owner-freebsd-current Thu Mar 21 8:54:32 2002 Delivered-To: freebsd-current@freebsd.org Received: from mail15.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by hub.freebsd.org (Postfix) with ESMTP id C665337B428 for ; Thu, 21 Mar 2002 08:54:20 -0800 (PST) Received: (qmail 11863 invoked from network); 21 Mar 2002 08:53:22 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail15.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 21 Mar 2002 08:53:22 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g2LGsrv66588; Thu, 21 Mar 2002 11:54:53 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020320235500.A11929@melusine.cuivre.fr.eu.org> Date: Thu, 21 Mar 2002 11:54:20 -0500 (EST) From: John Baldwin To: Thomas Quinot Subject: Re: i386/boot2.c patches Cc: freebsd-current@freebsd.org, Pierre Beyssac Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 20-Mar-2002 Thomas Quinot wrote: > Le 2002-03-20, John Baldwin écrivait : > >> Looks mostly ok to me. Not entirely sure about the autoboot changes >> as it looks weird to load(kname) right before you change what kname >> is. I think the logic must somehow be wrong there. > > But this is what is currently in the code (as I mentioned in the PR, > 36015 is strictly a code clarification, with no functional change). > The load() function in boot2 ends with an exec() of the loaded binary. > It returns only if it has failed. The purpose of replacing kname > after load() has returned is to try to load /boot/kernel if we have > failed to load /boot/loader. I was just saying it looked weird in the old code as well. Your explanation helps explain why though. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message