From owner-svn-src-all@FreeBSD.ORG  Tue Oct 11 14:54:44 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DD58E106564A;
	Tue, 11 Oct 2011 14:54:44 +0000 (UTC) (envelope-from jh@FreeBSD.org)
Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi
	[195.197.172.116])
	by mx1.freebsd.org (Postfix) with ESMTP id 91A658FC1A;
	Tue, 11 Oct 2011 14:54:44 +0000 (UTC)
Received: from jh (a91-153-115-208.elisa-laajakaista.fi [91.153.115.208])
	by gw02.mail.saunalahti.fi (Postfix) with ESMTP id E0F31139FB0;
	Tue, 11 Oct 2011 17:54:38 +0300 (EEST)
Date: Tue, 11 Oct 2011 17:54:38 +0300
From: Jaakko Heinonen <jh@FreeBSD.org>
To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@des.no>
Message-ID: <20111011145438.GB69508@jh>
References: <201110081221.p98CLpWq062285@svn.freebsd.org>
	<20111010145642.GA2057@a91-153-123-205.elisa-laajakaista.fi>
	<86hb3gj7ja.fsf@ds4.des.no> <20111011090049.GA69508@jh>
	<868vorkg1q.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <868vorkg1q.fsf@ds4.des.no>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r226151 - head/usr.bin/kdump
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2011 14:54:45 -0000

On 2011-10-11, Dag-Erling Smørgrav wrote:
> @@ -113,6 +114,8 @@
>  #define print_number(i,n,c) do {				\
>  	if (decimal)						\
>  		printf("%c%jd", c, (intmax_t)*i);		\
> +	else if (sizeof(*i) == sizeof(long))			\
> +		printf("%c%#lx", c, (unsigned long)*i);		\
>  	else							\
>  		printf("%c%#jx", c, (uintmax_t)*i);		\
>  	i++;							\

This assumes that sizeof(*i) is always sizeof(long) or
sizeof(uintmax_t). I prefer the fix bde suggested in another mail if
it's possible (I don't know if *i is always type of register_t).

-- 
Jaakko