From owner-cvs-all@FreeBSD.ORG Mon Apr 23 15:43:03 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 42C9A16A407 for ; Mon, 23 Apr 2007 15:43:03 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 12CCD13C458 for ; Mon, 23 Apr 2007 15:43:03 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 27987 invoked from network); 23 Apr 2007 15:43:00 -0000 Received: from ppp-71-139-34-102.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.34.102) by root.org with ESMTPA; 23 Apr 2007 15:43:00 -0000 Message-ID: <462CD3FD.6080300@root.org> Date: Mon, 23 Apr 2007 08:42:53 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (X11/20061027) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no> In-Reply-To: <86abwzio7t.fsf@dwp.des.no> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch fetch.3 ftp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2007 15:43:03 -0000 Dag-Erling Smørgrav wrote: > Nate Lawson writes: >> Log: >> Add back the original behavior of changing the entire directory path at >> once (CWD a/b/c vs. 3 CWDs). If an error occurs, we fall back to the default >> method of a single CWD per directory element. Since this is technically >> a violation of the basic FTP RFC > > Actually, it's a violation not of RFC959 (FTP) but of RFC1738 which > indicates how FTP URLs should be handled. > >> , this behavior is under a compile-time >> option FTP_COMBINE_CWDS and is off by default. It should work with most >> Unix-based FTP daemons and can save latency. > > Thanks. > > I'm going to set up a ports fetch run with FTP_COMBINE_CWDS enabled to > see how it works out in the ugly, real world. If it works out well, I > might replace the #ifdef with a command-line option or environment > variable for "strict RFC conformance". Thanks for doing the testing. -- Nate