From owner-svn-src-all@freebsd.org Sun Jan 19 17:10:41 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AF33C1FEB5B for ; Sun, 19 Jan 2020 17:10:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4811XJ4Pb6z4TH2 for ; Sun, 19 Jan 2020 17:10:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x830.google.com with SMTP id d18so25864304qtj.10 for ; Sun, 19 Jan 2020 09:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OVd6oNx4bt0g1J/6NKdvExHYGXe4YkVsrsh+J+x1hz4=; b=DFoGUVSThaZmtsaxlD6gXKv5EUgQ34w7pfDhx2luSoaB9pyc0kgPPpUch9C/3Hwdui fC+38+KM/M6w/ev81nasbP0aSrsiW1GK2/HQIgMYNHv9DCmsBgTzv4lu6vAhMOplSMG7 6vebqSoZCmvqj/KsoDhzGlUM46OB6JnIg54B1SRuUeoxwxUw2jmvGQ7HE7pDJl3rPwPC wMcahKBHd/8wr9Cd1wK5026vHtc7z9V9XgtSUdwJ+wa1Lue4AgJKu5tVnFPsGkVvknTD rxnSOKlFpbYZoYdFQdtuE45kMHSaFVw70dRbgooxSeTsemaNezaV67Gg0J9eTh95qy6D T3Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OVd6oNx4bt0g1J/6NKdvExHYGXe4YkVsrsh+J+x1hz4=; b=bX/umafvRsyv3hjfOz0KQUNowi6s4v4rLtnIaY0w1OYQ7i1+wcpITZQZCbXFffeLYD Gx+49g5+N2gC23zcpvXwJiWjf2pq/ejTDM6j+fLA1ktaH5hkcKcVRF+H81qhdloHvEod TOduVn3bQ2Xw23ZAE2vK7i751pJD8lNpeY/L8WK0XMAQf3rn+ruhQfbRsQ2LdPtbcpbU /jYkfjIdQPXTFn5H0NDv1So3LjLTiItMKccU+NxEakaJBd20RXqVKX15QLvtk8Py1Eq9 NI46BSc5JZj01L0j5QWCxiauHd1+QNcp+pVJqoFJOmmVFAwnXzxsfXKyVSHUAfgiWTtu Ohuw== X-Gm-Message-State: APjAAAU28eKF1IsmE5FlB3b/frPFB5e43C72LweJVj707KIPFuz3g99w HkKf8Pv4VfX710cIHAN0g3whlQHnUckzHjkDndqKPN37 X-Google-Smtp-Source: APXvYqyyK/b0BmJ2tz13nyMUkf3q+Ee9vM1pKgDPmbnUOyQbT87LmFgGWpZOHvUwpbYWZQa/ppueJoeQbcqG7PkLG8s= X-Received: by 2002:ac8:21ec:: with SMTP id 41mr17273492qtz.242.1579453839402; Sun, 19 Jan 2020 09:10:39 -0800 (PST) MIME-Version: 1.0 References: <202001191705.00JH5QRQ006755@repo.freebsd.org> In-Reply-To: <202001191705.00JH5QRQ006755@repo.freebsd.org> From: Warner Losh Date: Sun, 19 Jan 2020 10:10:28 -0700 Message-ID: Subject: Re: svn commit: r356883 - head/sys/kern To: Mateusz Guzik Cc: src-committers , svn-src-all , svn-src-head@freebsd.org X-Rspamd-Queue-Id: 4811XJ4Pb6z4TH2 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=DFoGUVST; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::830) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.64 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[0.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.64)[ip: (-9.26), ipnet: 2607:f8b0::/32(-2.08), asn: 15169(-1.82), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jan 2020 17:10:41 -0000 On Sun, Jan 19, 2020, 10:05 AM Mateusz Guzik wrote: > Author: mjg > Date: Sun Jan 19 17:05:26 2020 > New Revision: 356883 > URL: https://svnweb.freebsd.org/changeset/base/356883 > > Log: > cache: counter_u64_add_protected -> counter_u64_add > > Fixes booting on RISC-V where it does happen to not be equivalent. > Any reason we can't just have a counter64 API that works the same both places rather than hiding what looks to my eye to be just that behind ifdefs in vfs_cache.c? Warner Reported by: lwhsu > > Modified: > head/sys/kern/vfs_cache.c > > Modified: head/sys/kern/vfs_cache.c > > ============================================================================== > --- head/sys/kern/vfs_cache.c Sun Jan 19 16:24:25 2020 (r356882) > +++ head/sys/kern/vfs_cache.c Sun Jan 19 17:05:26 2020 (r356883) > @@ -412,14 +412,14 @@ static void > cache_numcachehv_inc(void) > { > > - counter_u64_add_protected(numcachehv, 1); > + counter_u64_add(numcachehv, 1); > } > > static void > cache_numcachehv_dec(void) > { > > - counter_u64_add_protected(numcachehv, -1); > + counter_u64_add(numcachehv, -1); > } > #else > static void >