From owner-svn-src-head@FreeBSD.ORG  Thu May 17 21:52:18 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 893A11065686;
	Thu, 17 May 2012 21:52:18 +0000 (UTC)
	(envelope-from rmacklem@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 747A88FC08;
	Thu, 17 May 2012 21:52:18 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q4HLqIZi018522;
	Thu, 17 May 2012 21:52:18 GMT
	(envelope-from rmacklem@svn.freebsd.org)
Received: (from rmacklem@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q4HLqIu0018520;
	Thu, 17 May 2012 21:52:18 GMT
	(envelope-from rmacklem@svn.freebsd.org)
Message-Id: <201205172152.q4HLqIu0018520@svn.freebsd.org>
From: Rick Macklem <rmacklem@FreeBSD.org>
Date: Thu, 17 May 2012 21:52:18 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r235568 - head/sys/fs/nfs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 May 2012 21:52:18 -0000

Author: rmacklem
Date: Thu May 17 21:52:17 2012
New Revision: 235568
URL: http://svn.freebsd.org/changeset/base/235568

Log:
  A problem with the NFSv4 server was reported by Andrew Leonard
  to freebsd-fs@, where the setfacl of an NFSv4 acl would fail.
  This was caused by the VOP_ACLCHECK() call for ZFS replying
  EOPNOTSUPP. After discussion with rwatson@, it was determined
  that a call to VOP_ACLCHECK() before doing VOP_SETACL() is not
  required. This patch fixes the problem by deleting the
  VOP_ACLCHECK() call.
  
  Tested by:	Andrew Leonard (previous version)
  MFC after:	1 week

Modified:
  head/sys/fs/nfs/nfs_commonacl.c

Modified: head/sys/fs/nfs/nfs_commonacl.c
==============================================================================
--- head/sys/fs/nfs/nfs_commonacl.c	Thu May 17 20:49:44 2012	(r235567)
+++ head/sys/fs/nfs/nfs_commonacl.c	Thu May 17 21:52:17 2012	(r235568)
@@ -468,9 +468,7 @@ nfsrv_setacl(vnode_t vp, NFSACL_T *aclp,
 		error = NFSERR_ATTRNOTSUPP;
 		goto out;
 	}
-	error = VOP_ACLCHECK(vp, ACL_TYPE_NFS4, aclp, cred, p);
-	if (!error)
-		error = VOP_SETACL(vp, ACL_TYPE_NFS4, aclp, cred, p);
+	error = VOP_SETACL(vp, ACL_TYPE_NFS4, aclp, cred, p);
 
 out:
 	NFSEXITCODE(error);