From owner-svn-src-head@FreeBSD.ORG Tue Aug 10 17:33:42 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD104106566B; Tue, 10 Aug 2010 17:33:42 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper-int.allbsd.org [IPv6:2001:2f0:104:e002::2]) by mx1.freebsd.org (Postfix) with ESMTP id 2C7688FC0A; Tue, 10 Aug 2010 17:33:41 +0000 (UTC) Received: from alph.d.allbsd.org (p2176-ipbf406funabasi.chiba.ocn.ne.jp [124.86.72.176]) (authenticated bits=128) by mail.allbsd.org (8.14.4/8.14.3) with ESMTP id o7AHX3W9058348; Wed, 11 Aug 2010 02:33:13 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.4/8.14.4) with ESMTP id o7AHWw9Y061345; Wed, 11 Aug 2010 02:33:01 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Wed, 11 Aug 2010 02:32:35 +0900 (JST) Message-Id: <20100811.023235.13138059.hrs@allbsd.org> To: olli@fromme.com From: Hiroki Sato In-Reply-To: <201008101623.o7AGNs7I042679@haluter.fromme.com> References: <20100810.093656.167578749323544001.imp@bsdimp.com> <201008101623.o7AGNs7I042679@haluter.fromme.com> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Wed_Aug_11_02_32_35_2010_096)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.95.3 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.3 (mail.allbsd.org [133.31.130.32]); Wed, 11 Aug 2010 02:33:17 +0900 (JST) X-Spam-Status: No, score=-99.4 required=13.0 tests=AWL,CONTENT_TYPE_PRESENT, RCVD_IN_CHINA, RCVD_IN_CHINA_KR, RCVD_IN_PBL, RCVD_IN_TAIWAN, SPF_SOFTFAIL, USER_IN_WHITELIST,X_MAILER_PRESENT autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gatekeeper.allbsd.org Cc: src-committers@FreeBSD.org, jilles@stack.nl, svn-src-all@FreeBSD.org, olli@FreeBSD.org, svn-src-head@FreeBSD.org, des@des.no, imp@bsdimp.com Subject: Re: svn commit: r211023 - head/usr.sbin/syslogd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2010 17:33:42 -0000 ----Security_Multipart(Wed_Aug_11_02_32_35_2010_096)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Oliver Fromme wrote in <201008101623.o7AGNs7I042679@haluter.fromme.com>: ol> -static int validate(struct sockaddr *, const char *); ol> -static void unmapped(struct sockaddr *); ol> +static int validate(struct sockaddr_storage *, const char *); ol> +static void unmapped(struct sockaddr_storage *); Why is s/struct sockaddr */struct sockaddr_storage */ needed here? Using (struct sockaddr *) as an argument looks reasonable to me since the struct sockaddr_storage is mostly for memory allocation, not for access via pointer. -- Hiroki ----Security_Multipart(Wed_Aug_11_02_32_35_2010_096)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkxhjTMACgkQTyzT2CeTzy2M+QCgv7jPtA5hpnrVsUKcVaKpDZM0 HvEAoNaLfSgUIXhijNx2jGFy12XlRBzK =kkRv -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Aug_11_02_32_35_2010_096)----