From owner-cvs-src@FreeBSD.ORG  Wed Sep  8 14:34:51 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CC87E16A4D0; Wed,  8 Sep 2004 14:34:51 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 464CD43D5C; Wed,  8 Sep 2004 14:34:51 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.13.1/8.13.1) with ESMTP id i88EVkLi047658;
	Wed, 8 Sep 2004 08:31:46 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Wed, 08 Sep 2004 08:32:15 -0600 (MDT)
Message-Id: <20040908.083215.102654981.imp@bsdimp.com>
To: green@FreeBSD.ORG
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20040908130741.GC928@green.homeunix.org>
References: <200409080713.i887Dd54058789@repoman.freebsd.org>
	<20040908.012031.93204322.imp@bsdimp.com>
	<20040908130741.GC928@green.homeunix.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/usb ugen.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Sep 2004 14:34:52 -0000

In message: <20040908130741.GC928@green.homeunix.org>
            Brian Fundakowski Feldman <green@FreeBSD.ORG> writes:
: On Wed, Sep 08, 2004 at 01:20:31AM -0600, M. Warner Losh wrote:
: > In message: <200409080713.i887Dd54058789@repoman.freebsd.org>
: >             Warner Losh <imp@FreeBSD.org> writes:
: > : imp         2004-09-08 07:13:39 UTC
: > : 
: > :   FreeBSD src repository
: > : 
: > :   Modified files:
: > :     sys/dev/usb          ugen.c 
: > :   Log:
: > :   Back out 1.88.
: >              1.87 I mean.
: > :   The reference counts are there to block detach until the sleepers in
: > :   read/write/ioctl have gotten out, not to prevent the open device from
: > :   going away.  Restore the old behavior so that we have a chance to wake
: > :   up sleepers when the usb device goes away, so they can properly return
: > :   EIO back to the caller when this happens.
: > :   
: > :   Otherwise, we have a guarnateed panic waiting to happen when a device
: > :   detaches with an active read channel.
: > :   
: > :   This should be merged to 5 asap.
: 
: Now I'll get guaranteed panics using both my Palm and any CardBus hardware.

Can you send me a traceback for that problem then?  The 'reference
count' here is very much supposed to be a 'how many sleepers do you
have' sort of thing and is present in nearly all of the usb drivers.

Warner