Date: Wed, 18 Mar 2020 16:52:52 +0000 From: Brooks Davis <brooks@freebsd.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359046 - head/share/mk Message-ID: <20200318165252.GB5399@spindle.one-eyed-alien.net> In-Reply-To: <20200318.122924.1446699160859237014.hrs@FreeBSD.org> References: <202003171817.02HIHWdY035423@repo.freebsd.org> <20200318.122924.1446699160859237014.hrs@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--gatW/ieO32f1wygP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 18, 2020 at 12:29:24PM +0900, Hiroki Sato wrote: > Brooks Davis <brooks@FreeBSD.org> wrote > in <202003171817.02HIHWdY035423@repo.freebsd.org>: >=20 > br> Author: brooks > br> Date: Tue Mar 17 18:17:32 2020 > br> New Revision: 359046 > br> URL: https://svnweb.freebsd.org/changeset/base/359046 > br> > br> Log: > br> Support SUBDIR.${MK_FOO}.${MK_BAR} expresssions. > br> > br> This allows simplification of Makefiles where some SUBDIR entries d= epend > br> on two things (e.g. something that depends on C++ and some other kn= ob). >=20 > Just my two cents, but SUBDIR.${MK_FOO:M${MK_BAR}:M${MK_BAZ}}=3D dir > should do the trick. I am not sure how many variables we need to > support in practice, adding ".yes.yes..." in bsd.subdir.mk looks less > flexible to me. IMO that's lousy from a readability perspective. It's remotely conceivable that supporting three variables might make sense, but more seems vanishingly unlikely and even so, it's trivial to add more cases. -- Brooks --gatW/ieO32f1wygP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJeclHkAAoJEKzQXbSebgfAEvAH+waQwS2gxFU3dm8cnEUXxf9e euWjpEqFiDP3T46gevnUKeIGlCJuiEZM2K++OdD0wtTv25BpSBVi/9IZztu1CdXN +N2nGht6xPTRXeK9GsLw5APEZj1m/NTql0ozVWX9GKmui8EcMGEmnY7S4kr4Gz73 9n/TdtS/BgpQHxaF9aoVCvqmRPvntqj6a5PtR4wxd4+JNsRbsLZ9shBGiL66EIts S8R0ZAosYr4EKS0fhKp5xQueup2LhSVXKEw8b48RtjAyZ3eLUZBBUP3sNSoW2UXf 29ipmeoXTcLQ54p5MutOGcEx5ec4af+pivrgslbli0cClMBadeFxKDpCNW6QliM= =aEng -----END PGP SIGNATURE----- --gatW/ieO32f1wygP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200318165252.GB5399>