From owner-svn-src-head@FreeBSD.ORG Tue Mar 9 21:06:17 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2F451065672; Tue, 9 Mar 2010 21:06:17 +0000 (UTC) (envelope-from ache@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C13598FC0C; Tue, 9 Mar 2010 21:06:17 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o29L6HNP030016; Tue, 9 Mar 2010 21:06:17 GMT (envelope-from ache@svn.freebsd.org) Received: (from ache@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o29L6HJv030014; Tue, 9 Mar 2010 21:06:17 GMT (envelope-from ache@svn.freebsd.org) Message-Id: <201003092106.o29L6HJv030014@svn.freebsd.org> From: "Andrey A. Chernov" Date: Tue, 9 Mar 2010 21:06:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r204928 - head/usr.bin/comm X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2010 21:06:17 -0000 Author: ache Date: Tue Mar 9 21:06:17 2010 New Revision: 204928 URL: http://svn.freebsd.org/changeset/base/204928 Log: Add SIZE_MAX overflow check Modified: head/usr.bin/comm/comm.c Modified: head/usr.bin/comm/comm.c ============================================================================== --- head/usr.bin/comm/comm.c Tue Mar 9 21:06:01 2010 (r204927) +++ head/usr.bin/comm/comm.c Tue Mar 9 21:06:17 2010 (r204928) @@ -201,6 +201,8 @@ convert(const char *str) if ((n = mbstowcs(NULL, str, 0)) == (size_t)-1) return (NULL); + if (SIZE_MAX / sizeof(*buf) < n + 1) + errx(1, "conversion buffer length overflow"); if ((buf = malloc((n + 1) * sizeof(*buf))) == NULL) err(1, "malloc"); if (mbstowcs(buf, str, n + 1) != n)