From owner-svn-src-head@FreeBSD.ORG Mon Jul 29 20:28:26 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1042743E for ; Mon, 29 Jul 2013 20:28:26 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm11-vm2.bullet.mail.ne1.yahoo.com (nm11-vm2.bullet.mail.ne1.yahoo.com [98.138.90.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A6B012E90 for ; Mon, 29 Jul 2013 20:28:25 +0000 (UTC) Received: from [98.138.101.129] by nm11.bullet.mail.ne1.yahoo.com with NNFMP; 29 Jul 2013 20:21:30 -0000 Received: from [98.138.226.31] by tm17.bullet.mail.ne1.yahoo.com with NNFMP; 29 Jul 2013 20:21:29 -0000 Received: from [127.0.0.1] by smtp202.mail.ne1.yahoo.com with NNFMP; 29 Jul 2013 20:21:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1375129289; bh=wrUqVHpNhwax5jGl1rmjD0P7cg9++7qZUy5oxtPcKDg=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=h6whPBfi4AWmFxpWZeInxQEH4eVoepHD/q6z+kSuC0ov5IBpBtA6HsFgXncJV9pfip4AIOC47bYtbWijfXb/O6yA+ETvAWDQaLdKKFu2Kcxp+cNqFXRQYdjEvdbTMrL3t6opQ+Q8BoKq7ZVmPH+pbRuO1Csm2cATLhqSqmiGJpI= X-Yahoo-Newman-Id: 768711.75058.bm@smtp202.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: ewJnRo0VM1lOgOJdPAkvpLLHhpjYZLllH0z0_R0jcwR13iN mUQT2yZ5kRcmxY_MFW3jdQr4mXnyBFGRJ_Kb8QF2ldqP3k1FhtG_zwLS5Q24 hp2.mBhGrDpt_ubEd2U767R3VB5h5slm7xnw8YefWhvz._ADqpsyOsDyRCke 1N33AFDwgpBp4Y.o34ssYQiYC3teqnPrOqotDu8fddd61ORwNAvKQ.J2tLYt pxK3WnH3qSr5Vcla9fRKCDcYPn8U3I517xcZsFyA2MLddwS_zjgHmAt1zrBu tDJEV9BXKUZnUHQoiuYL5NHvTTe1_O_ih_VsUO44cgsiS7jLWgD1vV2UEiTa eA7DvicvSAKGCs1tLkG8ZLcQq59lRH2Ft8aTXEGrD6eM455PWVJTkSJ7yOUQ KYamtXqqRO9Gmi3EUXCaIRBdH2SO9XcywPxxE6DG1zXAZHD7p9Ve0hZXmK0K 3ktrGIoWkmUiHKIHb00YbhSX4BnoQB4Y8ykYtnTdNs4.WPLl8VGYgXTDnH2p WumiWKg907kpVJcmGH7aIrPSKb_rteoOkpdzEv8SFq8uPmqIBtC64.UV9Xmq PZpx47P5.obaZ1GudLmM6f4_dugZ6p9PamDxV74MeYUblx6An7h2_XYpeO.D kIb3l5wk- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [10.73.160.242] (sean_bruno@209.131.62.116 with ) by smtp202.mail.ne1.yahoo.com with SMTP; 29 Jul 2013 13:21:29 -0700 PDT Subject: Re: svn commit: r253708 - head/sys/dev/ipmi From: Sean Bruno To: sbruno@freebsd.org In-Reply-To: <1375127952.1479.32.camel@localhost> References: <201307271632.r6RGWYF8046749@svn.freebsd.org> <201307291054.55820.jhb@freebsd.org> <1375127952.1479.32.camel@localhost> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-VDU4fb1zgiUJhY+rY5fu" Date: Mon, 29 Jul 2013 13:21:28 -0700 Message-ID: <1375129288.1479.36.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jul 2013 20:28:26 -0000 --=-VDU4fb1zgiUJhY+rY5fu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Mon, 2013-07-29 at 12:59 -0700, Sean Bruno wrote: > On Mon, 2013-07-29 at 10:54 -0400, John Baldwin wrote: > > On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote: > > > Author: sbruno > > > Date: Sat Jul 27 16:32:34 2013 > > > New Revision: 253708 > > > URL: http://svnweb.freebsd.org/changeset/base/253708 > > >=20 > > > Log: > > > At some point after stable/7 the ACPI and ISA interfaces to the IPM= I controller > > > no longer have the parent in the device tree. This causes the iden= tify > > > function in ipmi_isa.c to attempt to probe and poke at the ISA IPMI= interface > >=20 > > They never had a common parent, even in 6.x and 7.x. > >=20 > The identify function in isa_ipmi.c shows that there is already an > ipmi(4) device attached (ACPI) version and aborts on 7.x. in 9.x and > higher (not testing on 8.x) the identify function does not see an > attached ipmi interface and attempts to create /dev/ipmi1 >=20 > Am I just confused on the bus relationship here? >=20 > We've gone over this a couple of times in different emails on different > lists. I've just never sat down and walked through the code. If you > see a better way to keep ipmi(4) from erroneously attaching to the ISA > interface, let me know. Or ... ya know, I could just be 100% wrong? stable/7 attaches to an /dev/ipmi1 as well on these Dell R410 units. *sigh* http://people.freebsd.org/~sbruno/ipmi_sean_is_wrong.txt so, the modification I made does resolve the "ipmi1" thing alltogether and is correct (AFAIK), but should be applied to all revisions, not just 9/head. Or, am I wrong again? :-) Sean --=-VDU4fb1zgiUJhY+rY5fu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJR9s7IAAoJEBkJRdwI6BaHWbAH/Ra9Myclh3FUQde7XrcZcb16 yHtKbi8lOTKNriSxcS68K7XVBKqieVwGVXbwlhOuGbwyXbZd+Fu26P79D8Hutzio 33MucMX8PFTOKMOqr8dO3Ii/howf+gtopVXRJA2BiB4fFIA5f3Pnep7M+aUJPFSZ 8DQp071X3TmOezRLqRE404SD2dFf3tuQaWFNo7oEPKAdinrHa0HiXtXPz72sB7Dp 0C+l32Gng++kcHPZKbI69g9Rp7Fg2nbvFA6pBYDpFnwMulO9NvOUbRWsdkToxj1s R3seGx+lDiFvQeKzlG7SyyEe77XbC04Umahci9PF15hhVKwYMU6tOgsFtgbd2pw= =ldSc -----END PGP SIGNATURE----- --=-VDU4fb1zgiUJhY+rY5fu--