From owner-freebsd-current@FreeBSD.ORG Thu Oct 9 21:21:18 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8784F59A; Thu, 9 Oct 2014 21:21:18 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 62416D0F; Thu, 9 Oct 2014 21:21:18 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0E920B941; Thu, 9 Oct 2014 17:21:17 -0400 (EDT) From: John Baldwin To: Alfred Perlstein Subject: Re: [PATCH] Lock scd(4): test or the driver will be removed Date: Thu, 9 Oct 2014 14:02:22 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <3885426.QchWJeH1gV@ralph.baldwin.cx> <5435D59A.9090506@freebsd.org> In-Reply-To: <5435D59A.9090506@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <201410091402.22466.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 09 Oct 2014 17:21:17 -0400 (EDT) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 21:21:18 -0000 On Wednesday, October 08, 2014 8:23:54 pm Alfred Perlstein wrote: > > On 10/8/14 11:53 AM, John Baldwin wrote: > > This patch adds locking to scd(4) and marks it MPSAFE. It also uses bus_*() > > instead of bus_space_*(). The patch is against HEAD but probably applies to 9 > > and 10 as well. > > > > http://people.freebsd.org/~jhb/patches/scd_locking.patch > > > > Note that this driver is using a deprecated API that will be removed in 11. > > If no one tests updates to this driver then it is not feasible to continue > > maintaining it in the tree. In that case, it will be removed from HEAD one > > month from today. > > > Hey John, which APIs are being used? timeout(9). However, we are eventually going to start requiring drivers to not use Giant either (and retiring timeout(9) is a step in that direction). Also, most of these drivers are for ancient hardware. scd(4) is support for a relatively rare pre-ATA CD controller. The much-more common matcd(4) driver (which is the driver used by my old SoundBlaster 16 card that provided a CD controller (not just sound, but data as well)) was removed back in 2002. -- John Baldwin