From owner-freebsd-bugs@FreeBSD.ORG Thu Jun 5 01:40:14 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8C7637B401 for ; Thu, 5 Jun 2003 01:40:14 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 349E643FCB for ; Thu, 5 Jun 2003 01:40:14 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h558eDUp006782 for ; Thu, 5 Jun 2003 01:40:13 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h558eDVH006781; Thu, 5 Jun 2003 01:40:13 -0700 (PDT) Date: Thu, 5 Jun 2003 01:40:13 -0700 (PDT) Message-Id: <200306050840.h558eDVH006781@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Maxim Konovalov Subject: Re: misc/51955: pccard_ether textual errors X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Maxim Konovalov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2003 08:40:14 -0000 The following reply was made to PR misc/51955; it has been noted by GNATS. From: Maxim Konovalov To: Xander Cc: bug-followup@freebsd.org Subject: Re: misc/51955: pccard_ether textual errors Date: Thu, 5 Jun 2003 12:32:26 +0400 (MSD) On Thu, 8 May 2003, 10:20-0700, Xander wrote: [...] > >Description: > The comment in pccard_ether (rev 1.29) at the top mentions a third argument > for 'ifconfig_option'. This argument appears to be unused in the script. It is used, actually. Take a look at the line #87: # Do the primary ifconfig if specified ifconfig ${interface} ${ifconfig_args} $* -------------------------------------------------------^^ > There's also a typo (delelte) elsewhere in the script. > >How-To-Repeat: > > >Fix: > The following patch removes the remarks about the ifconfig_option and fixes > the typo. Whether removing the ifconfig_option explanation is the best way > to go is left to the maintainer of course. > > --- pccard_ether.rev1.29 Tue May 6 13:38:48 2003 > +++ pccard_ether Thu May 8 09:31:31 2003 > @@ -2,9 +2,9 @@ > # > # $FreeBSD: src/etc/pccard_ether,v 1.29 2003/05/05 19:06:46 ume Exp $ > # > -# pccard_ether interfacename [start|stop] [ifconfig option] > +# pccard_ether interfacename [start|stop] > # > -# example: pccard_ether ep0 start -link0 > +# example: pccard_ether ep0 start Funny but ep(4) does not support link0 option. What do you think about following patch: Index: etc/pccard_ether =================================================================== RCS file: /home/ncvs/src/etc/pccard_ether,v retrieving revision 1.30 diff -u -r1.30 pccard_ether --- etc/pccard_ether 12 May 2003 11:36:49 -0000 1.30 +++ etc/pccard_ether 5 Jun 2003 08:28:12 -0000 @@ -4,7 +4,7 @@ # # pccard_ether interfacename [start|stop] [ifconfig option] # -# example: pccard_ether ep0 start -link0 +# example: pccard_ether fxp0 start -link0 # stop_dhcp() { @@ -156,7 +156,7 @@ stop_dhcp ;; *) - # Delelte static route if specified + # Delete static route if specified eval ifx_routes=\$static_routes_${interface} if [ -n "${ifx_routes}" ]; then for i in ${ifx_routes}; do %%% -- Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org