From owner-freebsd-stable@FreeBSD.ORG Wed May 18 23:01:33 2005 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 11D5016A4D1 for ; Wed, 18 May 2005 23:01:33 +0000 (GMT) Received: from mailserver.sandvine.com (sandvine.com [199.243.201.138]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E47743D5E for ; Wed, 18 May 2005 23:01:32 +0000 (GMT) (envelope-from emaste@phaedrus.sandvine.ca) Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by mailserver.sandvine.com with Microsoft SMTPSVC(5.0.2195.6713); Wed, 18 May 2005 19:01:29 -0400 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 12627) id E15B911652; Wed, 18 May 2005 19:01:30 -0400 (EDT) Date: Wed, 18 May 2005 19:01:30 -0400 From: Ed Maste To: Doug White Message-ID: <20050518230130.GA18977@sandvine.com> References: <20050503115344.S26250@carver.gumbysoft.com> <20050506145902.GA51724@sandvine.com> <20050511202829.F11600@carver.gumbysoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050511202829.F11600@carver.gumbysoft.com> User-Agent: Mutt/1.4.2.1i X-OriginalArrivalTime: 18 May 2005 23:01:30.0062 (UTC) FILETIME=[870DF6E0:01C55BFD] cc: stable@freebsd.org Subject: Re: Experimental ttwwakeup() panic patch X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2005 23:01:33 -0000 On Wed, May 11, 2005 at 08:36:08PM -0700, Doug White wrote: > This is a problem mlaier and I may have fixed, at least against -CURRENT. > It appears that the process group alias in struct tty is accessed without > locking and its changing out from under us. > > Give this a try: > > http://people.freebsd.org/~mlaier/tty.t_pgrp.diff > > It compiles but I haven't actually booted a kernel with it, so YMMV. I applied the patch to our mostly-5.3 tree (with some modifiecations to ttyinfo() to get it to apply). It boots and passed the test that provoked the issue before. The crash only showed up on one nightly testrun out of dozens though, so I'm not certain it fixes the underlying issue. I'll let you know if anything else turns up. -- Ed Maste, Sandvine Incorporated