From owner-svn-src-all@FreeBSD.ORG Wed Jul 16 10:34:20 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B42E5352; Wed, 16 Jul 2014 10:34:20 +0000 (UTC) Received: from mail-we0-x236.google.com (mail-we0-x236.google.com [IPv6:2a00:1450:400c:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3DC7285C; Wed, 16 Jul 2014 10:34:19 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id q59so701326wes.27 for ; Wed, 16 Jul 2014 03:34:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=J6fCAKO782MtqnX7pPw5sB29a9gZsqg38hiQW1L+h54=; b=iGQYk6y7Gzlt++QrCWm6EAZkNon0o7M6ANqTKUvnaUj5+Twk2b0PEkg4VNKu32lvi5 uW69StIbdlMtkr7vGwh9TkANkCRv5R/sTrtkn5YGaGkWFL0Q+Exv8iIz/IrFI6JGnoG3 fSRoVJ7tAzXDuQMFo8fV0x9aB0zZJrSA0NX+T+eI0a+xGZMoM6trbeWntcrF+CeT3bqR aECrg5f5y5AsxwoEg13hRA+D50DOSeynjXuc9BkgWjjUyVqn/40Zj5GMeYBgj8Hekonr QhzqxXw1ixeki8hnjl+fZXn+7kbhoPdw0mYqtLoMUdQTyRSAgJgaYbZ2CsbDT2SldRyD zxLA== X-Received: by 10.194.91.228 with SMTP id ch4mr34832386wjb.59.1405506858092; Wed, 16 Jul 2014 03:34:18 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id nc19sm7480093wic.4.2014.07.16.03.34.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jul 2014 03:34:17 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 16 Jul 2014 12:34:11 +0200 From: Baptiste Daroussin To: Mateusz Guzik Subject: Re: svn commit: r268745 - in head/usr.bin: . timeout Message-ID: <20140716103411.GH48710@ivaldir.etoilebsd.net> References: <201407160955.s6G9taro084054@svn.freebsd.org> <20140716102908.GA17076@dft-labs.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YrQNB5Deg1WGKZi3" Content-Disposition: inline In-Reply-To: <20140716102908.GA17076@dft-labs.eu> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 10:34:20 -0000 --YrQNB5Deg1WGKZi3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote: > On Wed, Jul 16, 2014 at 09:55:36AM +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Wed Jul 16 09:55:36 2014 > > New Revision: 268745 > > URL: http://svnweb.freebsd.org/changeset/base/268745 > >=20 > > Log: > > New BSDL timeout(1) utility compatible with GNU timeout > > =20 > > it fully passes the GNU timeout regression tests, it is written in a = mostly > > portable way (only signal parsing is relying on non portable structur= es) > > =20 > > Phabric: D377 > >=20 > > +static sig_atomic_t sig_chld =3D 0; > > +static sig_atomic_t sig_term =3D 0; > > +static sig_atomic_t sig_alrm =3D 0; > > +static sig_atomic_t sig_ign =3D 0; > > + >=20 > No reason to se these explicitely to 0. >=20 > > +static void > > +usage(void) > > +{ > > + fprintf(stderr, "Usage: %s [--signal sig | -s sig] [--preserve-status= ]" > > + " [--kill-after time | -k time] [--foreground] " > > + " \n", getprogname()); > > + >=20 > Missing newline at the begnning. New line at the beginning? >=20 > > + exit(EX_USAGE); > > +} > > + > > + switch(signo) { > > + case 0: >=20 > sig 0? I doubt it is ever delivered. one of the tests from the GNU testsuite is passing 0 signal >=20 > > + if (timedout && !preserve) > > + pstat =3D EXIT_TIMEOUT; > > + >=20 > Bad indentation. right I'll fix regards, Bapt --YrQNB5Deg1WGKZi3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPGVSMACgkQ8kTtMUmk6Ey5XQCdFEqvPHJegoXlHyz+edknwxbz 8IgAn1SfQxtFaOhq9AmItPVHKUoSoW77 =Grex -----END PGP SIGNATURE----- --YrQNB5Deg1WGKZi3--