Date: Wed, 12 Oct 2016 16:25:00 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Konstantin Belousov <kib@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r306680 - in head/sys: amd64/amd64 amd64/include i386/include x86/include x86/x86 Message-ID: <425655dd-ba13-8944-0f31-b1ad6666d90a@FreeBSD.org> In-Reply-To: <201610041701.u94H1OK3061119@repo.freebsd.org> References: <201610041701.u94H1OK3061119@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/10/2016 20:01, Konstantin Belousov wrote: > Author: kib > Date: Tue Oct 4 17:01:24 2016 > New Revision: 306680 > URL: https://svnweb.freebsd.org/changeset/base/306680 > > Log: > Re-apply r306516 (by cem): > > Reduce the cost of TLB invalidation on x86 by using per-CPU completion flags > > Reduce contention during TLB invalidation operations by using a per-CPU > completion flag, rather than a single atomically-updated variable. Kostik, could this commit cause a problem reported in the below links? https://bz-attachments.freebsd.org/attachment.cgi?id=175614 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213371 > On a Westmere system (2 sockets x 4 cores x 1 threads), dtrace measurements > show that smp_tlb_shootdown is about 50% faster with this patch; observations > with VTune show that the percentage of time spent in invlrng_single_page on an > interrupt (actually doing invalidation, rather than synchronization) increases > from 31% with the old mechanism to 71% with the new one. (Running a basic file > server workload.) > > Submitted by: Anton Rang <rang at acm.org> > Reviewed by: cem (earlier version) > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D8041 -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?425655dd-ba13-8944-0f31-b1ad6666d90a>