Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Dec 2024 13:20:11 +0000
From:      bugzilla-noreply@freebsd.org
To:        toolchain@FreeBSD.org
Subject:   [Bug 276170] LLVM bug prevents from enabling PGO optimization for Python 3.11+
Message-ID:  <bug-276170-29464-rI1e1wyKqb@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-276170-29464@https.bugs.freebsd.org/bugzilla/>
References:  <bug-276170-29464@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276170

--- Comment #39 from Mark Millard <marklmi26-fbsd@yahoo.com> ---
The stable/14 test context got:

[00:00:07] [01] [00:00:00] Building   lang/python310 | python310-3.10.16
[00:07:55] [01] [00:07:48] Finished   lang/python310 | python310-3.10.16:
Success

for:

# cat ~/mmjnk.txt
diff --git a/lang/python310/Makefile b/lang/python310/Makefile
index b352e8a2f9d7..f09113380dcc 100644
--- a/lang/python310/Makefile
+++ b/lang/python310/Makefile
@@ -27,8 +27,10 @@ SHEBANG_FILES+=3D      Lib/test/ziptestdata/exe_with_z64=
 \

 DISABLED_EXTENSIONS=3D   _sqlite3 _tkinter _gdbm
 CONFIGURE_ARGS+=3D       --enable-shared --without-ensurepip \
-                       --with-system-ffi
-CONFIGURE_ENV+=3D                OPT=3D"" # Null out OPT to respect user C=
FLAGS
and remove optimizations
+                       --with-system-ffi --enable-optimizations
+CONFIGURE_ENV+=3D                CC=3Dclang
+#CONFIGURE_ENV+=3D               OPT=3D"" # Null out OPT to respect user C=
FLAGS
and remove optimizations
+CFLAGS+=3D               -O3

 INSTALL_TARGET=3D                altinstall=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20
        # Don't want cloberring of unprefixed files

@@ -45,7 +47,7 @@ PLIST_SUB=3D            ABI=3D${ABIFLAGS} \
                        OSMAJOR=3D${OSVERSION:C/([0-9]*)[0-9]{5}/\1/}=20=20=
=20=20=20=20=20=20=20=20=20=20
# For plat-freebsd* in pkg-plist. https://bugs.python.org/issue19554

 OPTIONS_DEFINE=3D                DEBUG IPV6 LIBMPDEC LTO NLS PYMALLOC
-OPTIONS_DEFAULT=3D       LIBMPDEC PYMALLOC
+OPTIONS_DEFAULT=3D       LIBMPDEC PYMALLOC LTO
 OPTIONS_EXCLUDE_riscv64=3D       LTO
 OPTIONS_RADIO=3D         HASH
 OPTIONS_RADIO_HASH=3D    FNV SIPHASH

that had commands like:

clang -pthread -c -Wno-unused-result -Wsign-compare -Wunreachable-code -DND=
EBUG
-g -fwrapv -O3 -Wall -O2 -pipe  -O3 -fstack-protector-strong
-fno-strict-aliasing   -flto -g -std=3Dc99 -Wextra -Wno-unused-result
-Wno-unused-parameter -Wno-missing-field-initializers
-Werror=3Dimplicit-function-declaration -fvisibility=3Dhidden
-fprofile-instr-generate -I./Include/internal  -I. -I./Include
-I/usr/local/include -I/usr/local/include -fPIC -DPy_BUILD_CORE -o
Programs/python.o ./Programs/python.c

So, the order: -O3 -O2 -O3

It does not appear like -O3 leads to any crashes for LLVM19's clang.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-276170-29464-rI1e1wyKqb>