From owner-svn-src-all@FreeBSD.ORG Mon Jul 9 15:06:18 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A28E0106566C; Mon, 9 Jul 2012 15:06:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 740438FC0C; Mon, 9 Jul 2012 15:06:18 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C9CC2B9AC; Mon, 9 Jul 2012 11:06:17 -0400 (EDT) From: John Baldwin To: Marcel Moolenaar Date: Mon, 9 Jul 2012 09:45:52 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) References: <201207061557.q66Fv45N069464@svn.freebsd.org> <20120707083535.GR2338@deviant.kiev.zoral.com.ua> <2B1DDEF4-A048-45BD-9A7A-8CB148282475@xcllnt.net> In-Reply-To: <2B1DDEF4-A048-45BD-9A7A-8CB148282475@xcllnt.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201207090945.52985.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 09 Jul 2012 11:06:17 -0400 (EDT) Cc: Konstantin Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar , src-committers@freebsd.org Subject: Re: svn commit: r238172 - head/sys/dev/agp X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 15:06:18 -0000 On Saturday, July 07, 2012 10:44:14 am Marcel Moolenaar wrote: > The commit log states the motivation: developers tend to copy-n-paste without > truly understanding the subtle differences and may use the Maxmem use in > agp_i810.c as the wrong precedence. Secondly, also mentioned in the commit > log, is the use of realmem in agp.c and then Maxmem in agp_i810.c which is > likely to be confusing. So the change from Maxmem to realmem in agp_i810.c > prioritizes the avoidance of confusion over pedantic correctness, which we > all know isn't achievable anyway. Since agp_i810.c is only for amd64, i386 > and pc98, also stated in the commit log, and all of those have dense phys. > memory, the discrepancy is still within the margin of error. 1GB is a rather large margin IMO. If agp_i810.c actually cares about the maximum PA and not the size of RAM, then it should use the correct variable for this purpose. The copy-n-paste thing works both ways. You don't want someone to use realmem instead of Maxmem elsewhere because they copy-n-paste the wrong thing from agp_i810.c. I think the solution is to fix things to use what the actually need. In the case of agp_i810.c it sounds like that is Maxmem. -- John Baldwin