Date: Sat, 6 Mar 2021 18:39:23 +0100 From: Rainer Hurling <rhurlin@gwdg.de> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: <ports-committers@freebsd.org>, <svn-ports-all@freebsd.org>, <svn-ports-head@freebsd.org> Subject: Re: svn commit: r561652 - in head/databases: libgda5-mdb mdbtools mdbtools/files recutils Message-ID: <b5c49b0c-0469-88f3-a709-103cb3e30ae9@gwdg.de> In-Reply-To: <20210306164305.GA32516@FreeBSD.org> References: <202101151716.10FHGPeF016819@repo.freebsd.org> <20210306164305.GA32516@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 06.03.21 um 17:43 schrieb Alexey Dokuchaev: > On Fri, Jan 15, 2021 at 05:16:25PM +0000, Rainer Hurling wrote: >> New Revision: 561652 >> URL: https://svnweb.freebsd.org/changeset/ports/561652 >> >> Log: >> databases/mdbtools: Update to 0.9.1 >> >> - Switch to a new fork on Github >> - Split NLS (gettext) as an option >> - Remove gmdb2 GUI (will come back as own port) >> >> Differential Revision: https://reviews.freebsd.org/D28118 > > DR subject says "update to 0.9.2", but the port was updated to 0.9.1, > are there some problems with 0.9.2? Oops, I am sorry. This was just a typo in the review. v0.9.2 wasn't even released that time. Now, I am in the preparation of v0.9.2, released on 2021-02-27. But there are some showstoppers, which we try to solve upstream before. > >> ... >> Modified: head/databases/mdbtools/Makefile >> ============================================================================== >> --- head/databases/mdbtools/Makefile Fri Jan 15 15:57:58 2021 (r561651) >> +++ head/databases/mdbtools/Makefile Fri Jan 15 17:16:25 2021 (r561652) >> @@ -1,8 +1,8 @@ >> -# Created by: Anders Nordby <anders@fix.no> > > We typically keep these lines out of respect to the original port author > and appreciation of their efforts. While they are optional for new ports, > one should not remove them unless under explicit concent of that person. > Did you obtain that from Anders? Yes, you are right. That should not have happened. I will try to be more careful next time. >> +USE_GITHUB= yes >> +GH_ACCOUNT= mdbtools > > This is the default valute for GH_ACCOUNT so no need to set it. Thanks for the hint. I should have known this. > >> Modified: head/databases/recutils/Makefile >> ============================================================================== >> --- head/databases/recutils/Makefile Fri Jan 15 15:57:58 2021 (r561651) >> +++ head/databases/recutils/Makefile Fri Jan 15 17:16:25 2021 (r561652) >> @@ -3,6 +3,7 @@ >> >> PORTNAME= recutils >> PORTVERSION= 1.8 >> +PORTREVISION= 1 > > You should've checked all consumer ports that they actually can build > against updated port, no just merely bump port revision, even if this > dependency is optional and disabled by default. There had been some > changes in public API so `databases/recutils' failed to build with MDB > option enabled. I've fixed the port in r567461 and enabled MDB by > default so this breakage could be caught earlier next time. Arghh, that slipped through. I'm really sorry to have caused you so much trouble and extra work. And I must honestly admit that I would not have managed the relatively difficult patch(es) for recutils on my own. Next time I will test against databases/recutils, before committing a new version of mdbtools. Please accept my apologies and thanks for all the advice. Rainer > > ./danfe >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b5c49b0c-0469-88f3-a709-103cb3e30ae9>