From owner-freebsd-ports  Sun Jul 14 08:57:50 1996
Return-Path: owner-ports
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id IAA14848
          for ports-outgoing; Sun, 14 Jul 1996 08:57:50 -0700 (PDT)
Received: from rover.village.org (rover.village.org [204.144.255.49])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id IAA14818
          for <freebsd-ports@freebsd.org>; Sun, 14 Jul 1996 08:57:45 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by rover.village.org (8.7.5/8.6.6) with SMTP id JAA09439; Sun, 14 Jul 1996 09:57:23 -0600 (MDT)
Message-Id: <199607141557.JAA09439@rover.village.org>
To: Peter Childs <pjchilds@imforei.apana.org.au>
Subject: Re: top 3.3 nit 
Cc: freebsd-ports@freebsd.org
In-reply-to: Your message of Sun, 14 Jul 1996 16:48:15 +0930
Date: Sun, 14 Jul 1996 09:57:22 -0600
From: Warner Losh <imp@village.org>
Sender: owner-ports@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

:  If you have . in your path, and are running "make install" (so i
:  guess your root) then your asking for trouble.

Odd.  top is the only thing so far that I've had a problem with.  I
did a make world with the same path.  So it is therefore a bug in the
top port.

:  Its pretty much accepted that root shouldn't have . in its path.

While true, it is irrelevant to the discussion at hand.  I should be
able to use sudo to install, or I should be able to install as me
(with dot in my path) to some other dir that I do have privs for.

However, this time I did a:

sudo make install

which inherits my env.  Root's default env doesn't have this, but I
don't even know my root password because I've used sudo so much.  We
don't like, in general, to run directly as root in the village due to
security concerns.

However, a simple patch will fix this.  I hope I put the mv in the
right place.  The install script is a bad attempt at having a bsd
compatible install, and should be moved out of harms way.

Warner

Index: Makefile
===================================================================
RCS file: /home/imp/FreeBSD/CVS/ports/sysutils/top/Makefile,v
retrieving revision 1.9
diff -c -r1.9 Makefile
*** Makefile	1996/02/17 10:41:42	1.9
--- Makefile	1996/07/14 15:52:35
***************
*** 21,26 ****
--- 21,27 ----
  pre-configure:
  	cp ${FILESDIR}/defaults ${WRKSRC}/.defaults
  	cp ${FILESDIR}/m_freebsd2.* ${WRKSRC}/machine
+ 	mv ${WRKSRC}/install ${WORKSRC}/install.dist
  
  post-install:
  	strip ${PREFIX}/bin/top