From owner-svn-src-head@freebsd.org Tue Jul 19 14:58:01 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2C9EB9E88F for ; Tue, 19 Jul 2016 14:58:01 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 558CE12A4 for ; Tue, 19 Jul 2016 14:58:01 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-wm0-x236.google.com with SMTP id o80so29888655wme.1 for ; Tue, 19 Jul 2016 07:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YkpmP7BmMjMhcJJZEE1H3ptxZaKu8lgb2+3bEwWgHeo=; b=Gade/jcB5glELTlPTVyIZQs05HwtJ+An09sruvLqCwng2iPAfNvemZo2AYlGv7BsOv I7s9iG+UHCTHtUIf1lUxq+ARxxl/ebJzWAJKh8FnO9umdTyeDENybbs9s6jQPlxDpn2z 4xTkP9adaf79FedtGD2In4evk0buYQhNjlvNc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YkpmP7BmMjMhcJJZEE1H3ptxZaKu8lgb2+3bEwWgHeo=; b=ffHBGunHanfEqrWtlW8aO6fWY42cY+3/3+QG6A+/ZeaitUcJ0d5q2+eIbUsH/m5buN NkHa0QbABP+levri08lUJvls7A4Rqs5Km0Sf7Ww/uqkDjdsDasddgO/vEoJyVW7pb5yj S/46uFLoCH9O0fVbDX7cJ2UuN7OFT9A+em7g+6HCYOMhEdIt2egZUGuyrXxy37aXfJyW UC4FGn2/aWrtAheXxFx4F1yXmAmpMrzVqq9Yo8ddYyRxp5oXKr9X2ZSbxU5/ePay0RAx yYaeuvGme3b/ZG4cxOw3+8OFqbu+qj8QEFPKSEMgsdpgafbbSv+OcdUc11ib23x1SZ39 1ibA== X-Gm-Message-State: ALyK8tKso/E5ZF/2AcDvqVZ41S+AuTMm9b4SYTToKjM+kvErudC1rOmI/fiFxGncUSqXUSIt X-Received: by 10.28.47.7 with SMTP id v7mr4823067wmv.38.1468940279691; Tue, 19 Jul 2016 07:57:59 -0700 (PDT) Received: from dhcp-a2de.meeting.ietf.org (dhcp-a2de.meeting.ietf.org. [31.133.162.222]) by smtp.gmail.com with ESMTPSA id a21sm6405214wma.10.2016.07.19.07.57.58 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jul 2016 07:57:58 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r302998 - head/sys/kern From: Randall Stewart In-Reply-To: <20160719135614.GE65494@FreeBSD.org> Date: Tue, 19 Jul 2016 16:57:57 +0200 Cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201607180929.u6I9T9Uw063705@repo.freebsd.org> <64C1543A-3EDE-4852-88EA-5B0B78FCF016@netflix.com> <58868615-8255-4D8B-BD9E-8E19A734CB6C@netflix.com> <5E551FA8-C779-45AE-B038-D8B51B53EEAA@netflix.com> <20160719122545.GC65494@FreeBSD.org> <03E667D5-A4C9-47B9-A8DD-49ECD0E2B7EB@netflix.com> <20160719135614.GE65494@FreeBSD.org> To: Glen Barber X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 14:58:01 -0000 Well=20 The code itself I had up on machines for probably about 2 months. But = then I switched over to Gleb=E2=80=99s changes here just recently .. which = caused me all kinds of fun :) I had to go back into Mercurial to pull back my changes.. I have had the resurrected changes running on my netflix machines for about 20 or so hours generating about anywhere from 14Gbps to 32Gbps depending on the = machine type. I plan on waiting until tomorrow to sync it down into the NF code base.=20= Note that if you do decide instead to roll back to the 10.x = kern_timeout.c you will need to roll back a bunch of tcp changes as well that use the new async_drain() interface. I am game either way for you to proceed.. I will commit this current = code to head as long as I hear no objections (from Gleb or others)=E2=80=A6. R > On Jul 19, 2016, at 3:56 PM, Glen Barber wrote: >=20 > On Tue, Jul 19, 2016 at 03:46:54PM +0200, Randall Stewart wrote: >> Glen: >>=20 >> My changes work.. I have them running in NF in at least 1/2 dozen = machines. >>=20 >=20 > For how long? What are the uptimes on these machines? >=20 > This is the blocker for 11.0-BETA2, and I don't want to see more > regressions being introduced at this point of the cycle. >=20 > Glen >=20 >> I am more than willing to commit them.. they actually are not much = different than >> whats in stable 10.. though I don=E2=80=99t know if the async-drain = was MFC=E2=80=99d there.. it >> needs to be in for TCP.. or else you will have yet another mess in = that >> respect (TCP depends on ASYNC-drain). >>=20 >> I can commit what I have.. if you like.. or not.. I really don=E2=80=99= t care (I hate kern_timeout.c :-o) >>=20 >> R >>> On Jul 19, 2016, at 2:25 PM, Glen Barber wrote: >>>=20 >>> On Tue, Jul 19, 2016 at 01:43:16PM +0200, Randall Stewart wrote: >>>> Gleb >>>>=20 >>>> Ok >>>>=20 >>>> I have now updated >>>>=20 >>>> https://reviews.freebsd.org/D7135 >>>>=20 >>>> You can take this or not=E2=80=A6 I really don=E2=80=99t care = either way=E2=80=A6 (you are welcome to >>>> own the kern_timeout.c code I hate it) :-) >>>>=20 >>>> Basically when you went off and re-factored kern_timeout.c I had = worked in parallel on fixing >>>> the bugs you were seeing.. There were three distinct problems that = I fixed=E2=80=A6 but then >>>> you had refactored the stop() routine.. and I thought ok.. thats = fine. I had actually thought about >>>> doing something similar to what you did and was too chicken to poke = that much at it.. it has >>>> always had a nasty habit of biting back when you make a lot of = changes :-D >>>>=20 >>>> I know my version has worked for quite some time in my testing so I = brought it back. >>>> Complete with its 3 return codes (I only recently switched to your = version and thus >>>> started having difficulties with leaks and crashes)=E2=80=A6. >>>>=20 >>>> You are welcome not to use this.. I know it works (it ran >>>> on a number of machines at NF last night.. and we will of course = continue testing >>>> it as we finish our dev testing for the upcoming OCA software = release).. For now >>>> this is what will be going out into the OCA=E2=80=99s at least :-) >>>>=20 >>>=20 >>> I'm honestly done with this topic, and at the point now where I'm >>> considering backing out all changes to callout(9) and related = changes to >>> the state they were at in stable/10. >>>=20 >>> This changes the KBI, and if it needs to be done, it needs to happen >>> now. We cannot wait for RC1 phase for this, and the amount of churn = to >>> get things into a working state with the current implementation far >>> outweighs the benefit of the dangers. >>>=20 >>> Glen >>>=20 >>=20 >> -------- >> Randall Stewart >> rrs@netflix.com >> 803-317-4952 >>=20 >>=20 >>=20 >>=20 >>=20 -------- Randall Stewart rrs@netflix.com 803-317-4952