From owner-svn-src-all@FreeBSD.ORG Wed Jul 16 12:19:05 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 78A8D202; Wed, 16 Jul 2014 12:19:05 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1973C213E; Wed, 16 Jul 2014 12:19:04 +0000 (UTC) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s6GCJ0Ob060707 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Jul 2014 15:19:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s6GCJ0Ob060707 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id s6GCJ0GH060706; Wed, 16 Jul 2014 15:19:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 16 Jul 2014 15:19:00 +0300 From: Konstantin Belousov To: Baptiste Daroussin Subject: Re: svn commit: r268750 - head/usr.bin/timeout Message-ID: <20140716121900.GX93733@kib.kiev.ua> References: <201407161141.s6GBfSbS034790@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U6vonYU9PXaZy4LQ" Content-Disposition: inline In-Reply-To: <201407161141.s6GBfSbS034790@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 12:19:05 -0000 --U6vonYU9PXaZy4LQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 16, 2014 at 11:41:28AM +0000, Baptiste Daroussin wrote: > Author: bapt > Date: Wed Jul 16 11:41:28 2014 > New Revision: 268750 > URL: http://svnweb.freebsd.org/changeset/base/268750 >=20 > Log: > Sort headers > Constify long options > Remove useless call to sigemptyset > properly check errno when waiting for a process status when a SIGCHLD i= s received >=20 > Modified: > head/usr.bin/timeout/timeout.c >=20 > Modified: head/usr.bin/timeout/timeout.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/timeout/timeout.c Wed Jul 16 11:30:04 2014 (r268749) > +++ head/usr.bin/timeout/timeout.c Wed Jul 16 11:41:28 2014 (r268750) > @@ -28,20 +28,18 @@ > #include > __FBSDID("$FreeBSD$"); > =20 > -#include > -#include > -#include > +#include > +#include > +#include > #include > +#include > #include > #include > #include > +#include > +#include > #include > #include > -#include > -#include > -#include > -#include > -#include This is not proper sorting. sys/*.h comes first, usermode headers second. > =20 > #define EXIT_TIMEOUT 124 > =20 > @@ -188,7 +186,7 @@ main(int argc, char **argv) > cpid =3D -1; > pgid =3D -1; > =20 > - struct option longopts[] =3D { > + const struct option longopts[] =3D { I noted that this should be static const, not just const. The curious tendency of late is people committing changes without getting final confirmation from reviewer. Asking to look at the patch before commit would avoid repo churn. --U6vonYU9PXaZy4LQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTxm2zAAoJEJDCuSvBvK1BAGkP/2wIJZC6QG3Qyg2ALrqgpas3 pekqgo/OmHc2bubBpjpbBfoL193O0VugmZTpJUeq8/F3IcUEqx3xUNz60XNI5K+R mSzZi2lp8J4M7czV56kMbzRxAaAbjHxDBePsRifYgWxsIG0IQc/K9Z2cmj6OTLXc Me+jq6OysJ6II0/mAmZTp8JQ0QcejlSip5VgK9domVzarQXk9b0214a0rK8djtOl IJltLPaCdPRsb69yRJsx3XL0j6J05OYwoXFSD3O4rqSb2zZq+OoojJAm3agA1F7n exxd/EHrQEZNgLG8lVASKbJivOeAVjMJ/S6PNcuOq+8jcCFMY8XbIuL3bNY7O9yd 8++MxlfrPPIJyoBCxWjAGS9X43V2IMVTF5fUQlrlk/eDwxnhFsc2RMUzoDmwJp8e TwOXYPRr3Nxcnb1a7cHyxMWTke3oMQbIghstGcTF5b6H+F1++Q3wnOcYDpIWIRMy vV3lib3LuHJsFHWuBV69VwkmXcSPTObF8HvmpM6EmODeeZFyP1hHvZYvI2GiEYqT HsuLjJJEqyogE/WvmcOtNJVYFIpOFJ0pK8ADAJb6bX6lBkFvegNnrZ9EAQDCdHK8 jETpBO6HwkRPlLwutkXB2/gxdhqzLzvEDK6+SwiualsVzRI6ka+ElVcgR4k6ByNC luweILmnUBEJVX20G2nh =oMM6 -----END PGP SIGNATURE----- --U6vonYU9PXaZy4LQ--