From owner-cvs-src@FreeBSD.ORG  Wed Jun 25 11:43:03 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A730C37B401; Wed, 25 Jun 2003 11:43:03 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3401B43FE1; Wed, 25 Jun 2003 11:43:03 -0700 (PDT)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 1C81A2ED428; Wed, 25 Jun 2003 11:43:03 -0700 (PDT)
Date: Wed, 25 Jun 2003 20:43:03 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20030625184303.GZ21011@elvis.mu.org>
References: <20030625132838.643CB37B415@hub.freebsd.org>
	<20030625113931.I72722@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030625113931.I72722@root.org>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Olivier Houchard <cognet@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_prot.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jun 2003 18:43:04 -0000

Nate Lawson wrote:
> On Wed, 25 Jun 2003, Olivier Houchard wrote:
> >   Modified files:
> >     sys/kern             kern_prot.c
> >   Log:
> >   At this point targp will always be NULL, so remove the useless if.
> >
> >   Revision  Changes    Path
> >   1.173     +0 -2      src/sys/kern/kern_prot.c
> >
> > --- src/sys/kern/kern_prot.c:1.172	Sun Jun 15 08:57:42 2003
> > +++ src/sys/kern/kern_prot.c	Wed Jun 25 06:28:32 2003
> > @@ -404,8 +404,6 @@
> >  	sx_xlock(&proctree_lock);
> >  	if (uap->pid != 0 && uap->pid != curp->p_pid) {
> >  		if ((targp = pfind(uap->pid)) == NULL) {
> > -			if (targp)
> > -				PROC_UNLOCK(targp);
> >  			error = ESRCH;
> >  			goto done;
> >  		}
> 
> Did you intend to remove the PROC_UNLOCK along with the 'if'?  It seems
> it is still needed since at least the proctree_lock is still held.

There is nothing to PROC_UNLOCK() here since pfind() returned NULL.  The
proctree_lock is unlocked at the done: label.

Cheers,
Maxime