From owner-svn-src-head@FreeBSD.ORG Wed Apr 15 18:52:30 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E7810706; Wed, 15 Apr 2015 18:52:29 +0000 (UTC) Received: from smtp2.wemm.org (smtp2.wemm.org [IPv6:2001:470:67:39d::78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp2.wemm.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C212D26A; Wed, 15 Apr 2015 18:52:29 +0000 (UTC) Received: from overcee.wemm.org (canning.wemm.org [192.203.228.65]) by smtp2.wemm.org (Postfix) with ESMTP id 094FC2A3; Wed, 15 Apr 2015 11:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=m20140428; t=1429123949; bh=agG+2+kvoVb1OzWQ5SyahUxR/PLHaJqqQvsju541QTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NFXXNiKDxWwsx5RjTsa9AhMMwzeWk8pP12CMp7GR4xRuMNipRdF13XuQ7wyAz+8gs Gs9xcIyk7TiPuXeTmX6iVrP9qF85J7ildqcvMt8deZxntdzF/PBUOZTnYoUCXA9HBs wW2gqiEK0wv2bhMxClu/PQWZ7bMGYD2xjSgGhNtU= From: Peter Wemm To: svn-src-all@freebsd.org Cc: Adrian Chadd , Tijl Coosemans , "svn-src-head@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r281550 - in head: . bin/csh contrib/smbfs/include/netsmb contrib/smbfs/lib/smb include lib/libarchive lib/libc/iconv lib/libc/locale lib/libiconv_modules/BIG5 lib/libiconv_modules/DECH... Date: Wed, 15 Apr 2015 11:52:23 -0700 Message-ID: <2920267.p4mEmZ8sTB@overcee.wemm.org> User-Agent: KMail/4.14.3 (FreeBSD/11.0-CURRENT; KDE/4.14.3; amd64; ; ) In-Reply-To: References: <201504150909.t3F99LFB048690@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2146302.DXk677FAmj"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 18:52:30 -0000 --nextPart2146302.DXk677FAmj Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Wednesday, April 15, 2015 11:29:19 AM Adrian Chadd wrote: > cc1: warnings being treated as errors > /usr/home/adrian/work/freebsd/embedded/head/src/bin/csh/../../contrib= /tcsh/s > h.func.c: In function 'iconv_catgets': > /usr/home/adrian/work/freebsd/embedded/head/src/bin/csh/../../contrib= /tcsh/s > h.func.c:2599: warning: passing argument 2 of 'dl_iconv' from incompa= tible > pointer type >=20 > -adrian >=20 > On 15 April 2015 at 02:09, Tijl Coosemans wrote: > > Author: tijl > > Date: Wed Apr 15 09:09:20 2015 > > New Revision: 281550 > > URL: https://svnweb.freebsd.org/changeset/base/281550 > >=20 > > Log: > > Remove the const qualifier from iconv(3) to comply with POSIX: > > http://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.h= tml > > =20 > > Adjust all code that calls iconv. [Massive commit diff quote trimmed] This is one of those unfortunate things. A mistake was made during the= =20 standards process that wasn't caught untill too late. It was corrected= , but=20 not until the damage was done. The short version is that in the posix = spec,=20 the man page had the wrong type (and made no sense), but the actual cod= e=20 definition in the include file spec was correct. So, a bunch of OS's used the text description as the source of truth. =20= Ports/libiconv is one. Others requested a formal clarification and the posix committee specifi= cally=20 said the include file spec (which makes sense) is the correct one and u= pdated=20 the man page to match the include file. Linux glibc uses the correct f= orm. When I originally pulled the trigger I used the incorrect ports/libicon= v form=20 because I didn't know any better and regretted it since. I'm glad the mistake has been fixed. However, this is a gift that keep= s on=20 giving. There will be loose ends like the warning above turning up in = odd=20 places for some time. We'll just have to deal with it, a bit of whacka= mole=20 will be required. :( =2D-=20 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI= 6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 --nextPart2146302.DXk677FAmj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJVLrNnAAoJEDXWlwnsgJ4EllcH/icJbOA04IpeLKJr+KAjFcdc 4Y/uNRw1TcKcEGdkjq4yCiTmL5KYgYgz3M9HJp2QONMguyRNeK6U69ObHSe9tDpo zKAuxhnscw5seR5qr174qlEyjL8bbnJ2zYKO2nATu1XnYicbE3XLVEBPmKn0P5YI JkyQjRFt/i4R3myldq9JcX++P8PS61TguLcLjs9xdjig02rZlffDRHO3/w80otpH gffbXb6Ktc46Jq19M+aRdT5uahYqlnZv87tGEvwcfvH5JAy4qJ1z4oCzt+rATmX4 F6NW6vd4FZ4aTk5Sy2RkYBXI4R7SyW9KTZIathryjvqIDH9sJ/m/J+yLkUuxj3c= =wNgE -----END PGP SIGNATURE----- --nextPart2146302.DXk677FAmj--