From owner-cvs-all@FreeBSD.ORG Mon Mar 22 07:43:15 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8EB216A4CE; Mon, 22 Mar 2004 07:43:15 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1E2043D1D; Mon, 22 Mar 2004 07:43:15 -0800 (PST) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i2MFhFGe079115; Mon, 22 Mar 2004 07:43:15 -0800 (PST) (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i2MFhFFX079114; Mon, 22 Mar 2004 07:43:15 -0800 (PST) (envelope-from rwatson) Message-Id: <200403221543.i2MFhFFX079114@repoman.freebsd.org> From: Robert Watson Date: Mon, 22 Mar 2004 07:43:15 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_gif.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2004 15:43:16 -0000 rwatson 2004/03/22 07:43:15 PST FreeBSD src repository Modified files: sys/net if_gif.c Log: Lock down global variables in if_gif: - Add gif_mtx, which protects globals. - Hold gif_mtx around manipulation of gif_softc_list. - Abstract gif destruction code into gif_destroy(), which tears down a softc after it's been removed from the global list by either module unload or clone destroy. - Lock gif_called, even though we know gif_called is broken with reentrant network processing. - Document an event ordering problem in gif_set_tunnel() that will need to be fixed. gif_softc fields not locked down in this commit. Revision Changes Path 1.43 +50 -9 src/sys/net/if_gif.c