Date: Tue, 12 Jan 2021 10:29:52 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: maintainer-feedback requested: [Bug 252602] www/py-notebook: Python kernel does not work since tornado websockets use Future Message-ID: <bug-252602-21822-867v6XjAlb@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-252602-21822@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-python (Nobody) <python@FreeBSD.org> for maintainer-feedback: Bug 252602: www/py-notebook: Python kernel does not work since tornado websockets use Future https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252602 --- Description --- Since tornado websockets use python Future, the python3 kernel crash at file /usr/local/lib/python3.7/site-packages/notebook/services/kernels/handlers.py at the line 207 https://github.com/jupyter/notebook/blob/57db70979b677b0c47cbecfbfbc3ba5b359bc0 b3/notebook/services/kernels/handlers.py#L207 if self.ws_connection is None or self.ws_connection.is_closing(): Here since self.ws_connection is a Future it does not have the member: is_closing A fix would be to wait for the Future result (with or without a timeout) : websocket = self.ws_connection.result() And then check for websocket.is_closing() The dirty fix would be to ignore the test on is_closing With the dirty fix the kernel run The github repos have over 2k issue, it is hard to find if this error was already reported there.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-252602-21822-867v6XjAlb>