From owner-svn-src-head@freebsd.org Thu Sep 20 18:39:23 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40D8110A5648 for ; Thu, 20 Sep 2018 18:39:23 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-22.consmr.mail.gq1.yahoo.com (sonic312-22.consmr.mail.gq1.yahoo.com [98.137.69.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C2F817986D for ; Thu, 20 Sep 2018 18:39:22 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 0.mw8GAVM1nP2n3wuiL4i0aG4EQi.xiI9lN58jWEAodnR1sD0gL9B0GllzMSwr9 f67Hi5qRKpm.OhNdjg6Z4klBwWzuDR8VQy9ElU0PqCeIm8SoC92LwSxGsHySb1ix5cmzY9vBT.XF hQ6e6ACZuQuxPIovdsDz4i8SxwACBtjPIGUp7o04Jgcg.Wt5rsedDY72Jp0fCjlYw0yJmIVIMlJi cK7Mga1ZLefqE9hnGjsOECenphszIHkbft8_CQDiz7SQwdPmAMIZqWA8XFz8N3kSmc18HSH4yb4s jjGgOiKQN0YYbh0TpgcJPgkFT_0DODtXbgO.fV0kDaHo4g3CRq6DI3iGbwgF4Vr7s7.qHGfgUyNf 7ukBE9MRSbu758AWPlf9zv7ExdsSTRi2v0Y_owYVvLQUc7JiNfTNKXKXShryAz_.K6pququpuLAw 658kw6_uxOHITi7RossV2NnMKLnBd0FhwxXqwEhXA3Oqsml94p.hDCy.LuKePjv5UDYDjCAvC73c C4.oVYcilbrL9zqjXHomm.llK8Yo_BKc.ge2OnjbSEY1CNJ6l1YAfidBq2SEAUSpCyPDol2ixbaP 0qNU2TYdBqJ.xNy1iltIp5uuLxL3PHz4KOQQPwSI2sfpUNBLm5boNHQdAZfl6YWbNX66xidsbZVR 7J4jQ1JyvFPhUjkAveQtEVUplBH7TiMxTombO1JjmD9McOMfgp2SJ4PUY7AOtsfwtQ5gOFJpJfDz zk.jVxtLIeG5ePT1qnLM0uU3kfEa0p5eFKd35T83wJsff4aDOEahhiQNrfUGITMceX.LudiyVjSR VfF71ylE4itlLLb315wgGFZjowbGxu1TMqBF2e0a3MvsFo5YPokL68QO8rDN12bLDL1EskRztwVV hEMIMYu5UK_nfwJuHq4jAfLLKuUac.LpxFu83bo8Sbb2_HQAyzsbLVhiNUVjn1ObnhbKz2ebtoBp uv5GLWLDQcaUf_eZ.AY73_vvcl3ZIP899DwX3DvFo50iInRB9IRcOcKxDZkSVUVlnXczURqrODC4 z7sNroqB8 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Thu, 20 Sep 2018 18:39:15 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp420.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 164d462b1d2135f88b2d29934995be1b; Thu, 20 Sep 2018 18:29:05 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src Message-Id: Date: Thu, 20 Sep 2018 11:29:04 -0700 To: John Baldwin , svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 18:39:23 -0000 John Baldwin jhb at FreeBSD.org wrote on Thu Sep 20 16:39:27 UTC 2018 : > On 9/20/18 8:54 AM, Mark Johnston wrote: > > On Sun, Jul 15, 2018 at 12:23:11AM +0000, Matt Macy wrote: > >> Author: mmacy > >> Date: Sun Jul 15 00:23:10 2018 > >> New Revision: 336299 > >> URL: https://svnweb.freebsd.org/changeset/base/336299 > >> > >> Log: > >> msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd > >> =20 > >> This corresponds to the latest status (hasn't changed in 9+ > >> years) from openbsd of ld80/ld128 powl, and source cpowf, cpow, > >> cpowl (the complex power functions for float complex, double > >> complex, and long double complex) which are required for C99 > >> compliance and were missing from FreeBSD. Also required for > >> some numerical codes using complex numbered Hamiltonians. > >> =20 > >> Thanks to jhb for tracking down the issue with making > >> weak_reference compile on powerpc. > >> =20 > >> When asked to review, bde said "I don't like it" - but > >> provided no actionable feedback or superior implementations. > >> =20 > >> Discussed with: jhb > >> Submitted by: jmd > >> Differential Revision: https://reviews.freebsd.org/D15919 > >=20 > > This seems to have broken the gcc build: > > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/ > >=20 > > /workspace/src/lib/msun/ld80/e_powl.c:275:1: error: floating = constant exceeds range of 'long double' [-Werror=3Doverflow] > > if( y >=3D LDBL_MAX ) > > ^~ >=20 > Which architecture? i386 doesn't get build with i386-xtoolchain-gcc = pending > some patches I haven't yet posted for review related to the weirdness = we do > with floating point on i386. Looking at: https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/7260/consoleText (the most recent completed build attempt when I looked) It is the same as the 2018-Jun-28 list report about lib32 failing to build in the amd64 build (that lead to your ports' head -r475290): --- lib/msun__L --- --- e_powl.o --- /usr/local/bin/x86_64-unknown-freebsd11.1-gcc -DCOMPAT_32BIT -march=3Di686= -mmmx -msse -msse2 -m32 = -L/workspace/obj/workspace/src/amd64.amd64/obj-lib32/tmp/usr/lib32 = --sysroot=3D/workspace/obj/workspace/src/amd64.amd64/obj-lib32/tmp = -B/usr/local/x86_64-unknown-freebsd11.1/bin/ = -B/workspace/obj/workspace/src/amd64.amd64/obj-lib32/tmp/usr/lib32 -O2 = -pipe -I/workspace/src/lib/msun/x86 -I/workspace/src/lib/msun/ld80 = -I/workspace/src/lib/msun/i387 -I/workspace/src/lib/msun/src = -I/workspace/src/lib/libc/include -I/workspace/src/lib/libc/i386 -g = -MD -MF.depend.e_powl.o -MTe_powl.o -std=3Dgnu99 = -fstack-protector-strong -Wsystem-headers -Werror -Wno-pointer-sign = -Wno-error=3Daddress -Wno-error=3Darray-bounds -Wno-error=3Dattributes = -Wno-error=3Dbool-compare -Wno-error=3Dcast-align -Wno-error=3Dclobbered = -Wno-error=3Denum-compare -Wno-error=3Dextra -Wno-error=3Dinline = -Wno-error=3Dlogical-not-parentheses -Wno-error=3Dstrict-aliasing = -Wno-error=3Duninitialized -Wno-error=3Dunused-but-set-variable = -Wno-error=3Dunused-function -Wno-error=3Dunused-value = -Wno-error=3Dmisleading-indentation -Wno-error=3Dnonnull-compare = -Wno-error=3Dshift-negative-value -Wno-error=3Dtautological-compare = -Wno-error=3Dunused-const-variable -Wno-unknown-pragmas -c = /workspace/src/lib/msun/ld80/e_powl.c -o e_powl.o --- secure/lib/libcrypto__L --- . . . --- lib/msun__L --- /workspace/src/lib/msun/ld80/e_powl.c: In function 'powl': /workspace/src/lib/msun/ld80/e_powl.c:275:1: error: floating constant = exceeds range of 'long double' [-Werror=3Doverflow] if( y >=3D LDBL_MAX ) ^~ /workspace/src/lib/msun/ld80/e_powl.c:286:1: error: floating constant = exceeds range of 'long double' [-Werror=3Doverflow] if( y <=3D -LDBL_MAX ) ^~ /workspace/src/lib/msun/ld80/e_powl.c:297:1: error: floating constant = exceeds range of 'long double' [-Werror=3Doverflow] if( x >=3D LDBL_MAX ) ^~ /workspace/src/lib/msun/ld80/e_powl.c:321:1: error: floating constant = exceeds range of 'long double' [-Werror=3Doverflow] if( x <=3D -LDBL_MAX ) ^~ /workspace/src/lib/msun/ld80/e_powl.c: In function 'powil': /workspace/src/lib/msun/ld80/e_powl.c:577:3: error: floating constant = exceeds range of 'long double' [-Werror=3Doverflow] return( LDBL_MAX ); ^~~~~~ Your ports' head -r475290 does avoid the problem and allow such builds but ci.freebsd.org has not updated to some version with the changes as I understand. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)