From owner-cvs-all Mon Jul 26 2: 6: 7 1999 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id A58C8152DF; Mon, 26 Jul 1999 02:06:00 -0700 (PDT) (envelope-from des@flood.ping.uio.no) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.1) id LAA02489; Mon, 26 Jul 1999 11:05:59 +0200 (CEST) (envelope-from des) To: "Brian F. Feldman" Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/inetd Makefile References: From: Dag-Erling Smorgrav Date: 26 Jul 1999 11:05:59 +0200 In-Reply-To: "Brian F. Feldman"'s message of "Mon, 26 Jul 1999 04:57:27 -0400 (EDT)" Message-ID: Lines: 31 X-Mailer: Gnus v5.5/Emacs 19.34 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk "Brian F. Feldman" writes: > Here's one way to start cleaning it up: remove OLD_SETPROCTITLE cruft. patches? > Problem: is this line right? > syslog(LOG_ERR, "pipe: %%m"); probably not, there should be only one %. > Another: (type *)0 should be NULL. Lots of those. patches? > SWAP should die. typeof() is not portable. SWAP could take a type specifier as a third argument (I'd place it first, actually). > turnon() is lame, and should be shot. patches? > Lots more bogus casts. For instance: > sep = (struct servtab *)malloc(sizeof (*sep)); patches? DES -- Dag-Erling Smorgrav - des@flood.ping.uio.no To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message