From owner-freebsd-ports@FreeBSD.ORG  Fri Jul 22 02:54:04 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2D02616A49E
	for <ports@freebsd.org>; Fri, 22 Jul 2005 02:54:04 +0000 (GMT)
	(envelope-from mezz7@cox.net)
Received: from lakermmtai16.cox.net (lakermmtai16.cox.net [68.230.240.43])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6A80B43DBD
	for <ports@freebsd.org>; Fri, 22 Jul 2005 02:53:47 +0000 (GMT)
	(envelope-from mezz7@cox.net)
Received: from mezz.mezzweb.com ([68.103.32.140]) by lakermmtao06.cox.net
	(InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP
	id <20050722025258.HKIH17542.lakermmtao06.cox.net@mezz.mezzweb.com>;
	Thu, 21 Jul 2005 22:52:58 -0400
Date: Thu, 21 Jul 2005 21:54:42 -0500
To: "Paul Schmehl" <pauls@utdallas.edu>
References: <04AB93A9833EB439696DFBDF@Paul-Schmehls-Computer.local>
From: "Jeremy Messenger" <mezz7@cox.net>
Content-Type: text/plain; format=flowed; delsp=yes; charset=us-ascii
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID: <op.suanpgzb9aq2h7@mezz.mezzweb.com>
In-Reply-To: <04AB93A9833EB439696DFBDF@Paul-Schmehls-Computer.local>
User-Agent: Opera M2/8.01 (Linux, build 1204)
Cc: ports@freebsd.org
Subject: Re: Strange portlint error
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2005 02:54:04 -0000

On Thu, 21 Jul 2005 21:39:44 -0500, Paul Schmehl <pauls@utdallas.edu>  
wrote:

> I just ran portlint on a new port I'm working on, and I got the  
> following error:
>
> portlint -N
> WARN: Makefile: COMMENT should begin with a capital, and end without a  
> period

Read here, it said 'end without a period'.

> 0 fatal errors and 1 warnings found.
>
> Here's the comment:
>
> COMMENT=        Squil is a network security management program.
>
> As you can see, it has a period.  If I remove the period, portlint  
> returns "looks fine".

That's expect behavior.

http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-comment.html

Cheers,
Mezz

> Line 2054 of portlint reads:
>
> if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} =~  
> m/\.$/)) { #"
>
> It should be:
>
> if (($makevar{COMMENT} !~ /^["0-9A-Z]/) || ($makevar{COMMENT} !~  
> m/\.$/)) { #"
>
> This patch will fix it:
>
> --- portlint.orig       Thu Jul 21 21:40:24 2005
> +++ portlint    Thu Jul 21 21:38:46 2005
> @@ -2050,7 +2050,7 @@
>                 &perror("WARN: $file: unless this is a master port,  
> COMMENT has to be set by \"=\", ".
>                         "not by \"$1=\".") unless ($masterport);
>         } else { # check for correctness
> -               if (($makevar{COMMENT} !~ /^["0-9A-Z]/) ||  
> ($makevar{COMMENT} =~ m/\.$/)) { #"
> +               if (($makevar{COMMENT} !~ /^["0-9A-Z]/) ||  
> ($makevar{COMMENT} !~ m/\.$/)) { #"
>                         &perror("WARN: $file: COMMENT should begin with  
> a capital, and end without a period");
>                 } elsif (length($makevar{COMMENT}) > 70) {
>                         &perror("WARN: $file: COMMENT exceeds 70  
> characters limit.");
>
> Paul Schmehl (pauls@utdallas.edu)
> Adjunct Information Security Officer
> University of Texas at Dallas
> AVIEN Founding Member
> http://www.utdallas.edu/


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org