From owner-p4-projects@FreeBSD.ORG Tue Oct 16 17:56:37 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1F0C716A46D; Tue, 16 Oct 2007 17:56:37 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3721B16A418; Tue, 16 Oct 2007 17:56:36 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from mojo.ru (mojo.ru [84.252.152.63]) by mx1.freebsd.org (Postfix) with ESMTP id 9731D13C455; Tue, 16 Oct 2007 17:56:35 +0000 (UTC) (envelope-from cnst@FreeBSD.org) Received: from [192.168.0.16] (nc-76-6-108-199.dhcp.embarqhsd.net [76.6.108.199]) (authenticated bits=0) by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l9GHukSV005492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Oct 2007 21:56:48 +0400 Message-ID: <4714FB43.8000205@FreeBSD.org> Date: Tue, 16 Oct 2007 13:56:19 -0400 From: "Constantine A. Murenin" Organization: Google Summer of Code 2007 Student @ The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.7.5) Gecko/20041217 X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su MIME-Version: 1.0 To: Hans Petter Selasky References: <200709231625.l8NGPhaR097038@repoman.freebsd.org> <200709232113.34718.hselasky@freebsd.org> <20071016043133.GW31826@elvis.mu.org> <200710161823.59940.hselasky@freebsd.org> In-Reply-To: <200710161823.59940.hselasky@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Perforce Change Reviews , Alfred Perlstein , "Constantine A. Murenin" Subject: Re: PERFORCE change 126745 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 17:56:37 -0000 On 16/10/2007 12:23, Hans Petter Selasky wrote: > On Tuesday 16 October 2007, Alfred Perlstein wrote: > >>* Hans Petter Selasky [070923 13:13] wrote: >> >>>Hi Constantine, >>> >>>Thanks for your input and I _know_ that my code is not 100% style >>>compliant. Most of the style misbehaves are probably there due to the way >>>my "xemacs" autoformatting behaves. And I love curly brackets and >>>parenthesis, by the way :-) >>> >>>My plan is to clean up all the style stuff by a small C-program in the >>>end, because doing it by hand is waste of my time. Probably it will take >>>less time to write that program than the actual manual edit when we are >>>talking about doing alot of edits. It wonders me if such a tool already >>>exists, because the code is technically OK. >>> >>>Anyone that wants to be a little more constructive and point towards >>>where the FreeBSD style transformer program is? I assume it would be >>>extremely useful to everyone that is forced to use multiple different >>>styles depending on what project they are contributing to, like me. Then >>>before commit I will run that script and verify the differences. And >>>that's it. >>> >>>--HPS >> >>Hans, one of the issues with doing such changes at the end is that it >>effectively obliterates the ability to "cvs annotate" your code. I'm >>sure perforce has an 'annotate' command as well. >> >>I would suggest that you find/fix the style now and apply it now rather >>than later as the longer you wait, the more history you obliterate. > > > Hi Alfred, > > I never heard about the annotate command. Can you explain a little bit how it > works? > > I will do as you want and write that "style converter" first, before any other > changes. I expect it might take a little bit time, something like a week. > > --HPS The cvs annotate command displays which line was introduced in which revision and who introduced it. Just run `cvs annotate` on any file. Sometimes this feature is called CVS Blame in web-interfaces: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/intl/locale/src/nsScriptableDateFormat.cpp&rev=1.26 Cheers, Constantine.