From owner-svn-src-head@freebsd.org Tue Jul 14 12:02:57 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAE9199C988; Tue, 14 Jul 2015 12:02:57 +0000 (UTC) (envelope-from zbb@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B5F9E44; Tue, 14 Jul 2015 12:02:57 +0000 (UTC) (envelope-from zbb@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t6EC2v6I057627; Tue, 14 Jul 2015 12:02:57 GMT (envelope-from zbb@FreeBSD.org) Received: (from zbb@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t6EC2vaQ057626; Tue, 14 Jul 2015 12:02:57 GMT (envelope-from zbb@FreeBSD.org) Message-Id: <201507141202.t6EC2vaQ057626@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: zbb set sender to zbb@FreeBSD.org using -f From: Zbigniew Bodek Date: Tue, 14 Jul 2015 12:02:57 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r285534 - head/sys/arm64/arm64 X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 12:02:57 -0000 Author: zbb Date: Tue Jul 14 12:02:56 2015 New Revision: 285534 URL: https://svnweb.freebsd.org/changeset/base/285534 Log: Fix secondary PIC initialization order Call arm_init_secondary before any other PIC-related functions are called. This is necessary for GICv3 where PIC_INIT_SECONDARY allocates resources needed for all further operations. Obtained from: Semihalf Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D3066 Modified: head/sys/arm64/arm64/mp_machdep.c Modified: head/sys/arm64/arm64/mp_machdep.c ============================================================================== --- head/sys/arm64/arm64/mp_machdep.c Tue Jul 14 11:59:43 2015 (r285533) +++ head/sys/arm64/arm64/mp_machdep.c Tue Jul 14 12:02:56 2015 (r285534) @@ -229,6 +229,9 @@ init_secondary(uint64_t cpu) pcpup->pc_curthread = pcpup->pc_idlethread; pcpup->pc_curpcb = pcpup->pc_idlethread->td_pcb; + /* Configure the interrupt controller */ + arm_init_secondary(); + for (i = 0; i < COUNT_IPI; i++) arm_unmask_ipi(i); @@ -239,9 +242,6 @@ init_secondary(uint64_t cpu) vfp_init(); #endif - /* Configure the interrupt controller */ - arm_init_secondary(); - /* Enable interrupts */ intr_enable();