Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Jun 2006 07:45:38 GMT
From:      Sam Lawrance <lawrance@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 99665 for review
Message-ID:  <200606200745.k5K7jcmP079913@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=99665

Change 99665 by lawrance@dirk on 2006/06/20 07:45:21

	Don't build functions which call other functions we don't have.
	These are unused and were optimised away with -O2 in CFLAGS, so
	the link errors didn't show up by default.
	
	Discussed with:	Peter Jeremy

Affected files ...

.. //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_open.c#14 edit
.. //depot/projects/dtrace/src/contrib/opensolaris/tools/ctf/cvt/ctfmerge.c#4 edit

Differences ...

==== //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_open.c#14 (text) ====

@@ -841,6 +841,7 @@
 	*provmod = NULL;
 }
 
+#if defined(sun)
 static const char *
 dt_get_sysinfo(int cmd, char *buf, size_t len)
 {
@@ -855,6 +856,7 @@
 
 	return (buf);
 }
+#endif
 
 static dtrace_hdl_t *
 dt_vopen(int version, int flags, int *errp,

==== //depot/projects/dtrace/src/contrib/opensolaris/tools/ctf/cvt/ctfmerge.c#4 (text) ====

@@ -231,14 +231,13 @@
 	    progname, progname);
 }
 
+#if defined(sun)
 static void
 bigheap(void)
 {
 	size_t big, *size;
 	int sizes, i;
-#if defined(sun)
 	struct memcntl_mha mha;
-#endif
 
 	/*
 	 * First, get the available pagesizes.
@@ -267,7 +266,6 @@
 	if (brk((void *)((((uintptr_t)sbrk(0) - 1) & ~(big - 1)) + big)) != 0)
 		return;
 
-#if defined(sun)
 	/*
 	 * Finally, set our heap to use the largest page size for which the
 	 * MC_HAT_ADVISE doesn't return EAGAIN.
@@ -284,8 +282,8 @@
 		if (errno != EAGAIN)
 			break;
 	}
+}
 #endif
-}
 
 static void
 finalize_phase_one(workqueue_t *wq)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606200745.k5K7jcmP079913>