From owner-svn-src-all@freebsd.org Tue Jan 29 04:10:39 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5598414AA391 for ; Tue, 29 Jan 2019 04:10:39 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1F91C6A15F for ; Tue, 29 Jan 2019 04:10:39 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 9DF6AB689 for ; Tue, 29 Jan 2019 04:10:38 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f42.google.com with SMTP id a8so13566901lfk.5 for ; Mon, 28 Jan 2019 20:10:38 -0800 (PST) X-Gm-Message-State: AJcUukfIhoESnrBRBpilORi8ayRcfFU2F5CvjCwrqCT3+DSvNwNQMr7f PORWEfiHYazWSrMiMsFiyxxzO2IEj65xOAGt97g= X-Received: by 2002:a19:920a:: with SMTP id u10mt8269460lfd.122.1548735037049; Mon, 28 Jan 2019 20:10:37 -0800 (PST) MIME-Version: 1.0 References: <201901290408.x0T48oJQ080243@repo.freebsd.org> In-Reply-To: <201901290408.x0T48oJQ080243@repo.freebsd.org> From: Kyle Evans Date: Mon, 28 Jan 2019 22:10:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r343543 - head/sbin/bectl/tests Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1F91C6A15F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.967,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 04:10:39 -0000 On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans wrote: > > Author: kevans > Date: Tue Jan 29 04:08:49 2019 > New Revision: 343543 > URL: https://svnweb.freebsd.org/changeset/base/343543 > > Log: > bectl(8) test: Force destroy the zpool in cleanup > > This is a wild guess as to why bectl tests failed once upon a time in CI, > given no apparent way to see a transcript of cleanup routines with Kyua. The > bectl tests construct a new, clean zpool for every test. The failure > indicated was because of a mount that was leftover from a previous test, but > the previous test had succeeded so it's not clear how the mount remained > leftover unless the `zpool get health ${pool}` had somehow failed. > I left out: the tests are supposed to be constructed to clean up any mounts that were left over in the course of the test, hence the assumption that the failure lies in the cleanup.