From nobody Tue Mar 3 19:26:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQQl83kfgz6TX0h for ; Tue, 03 Mar 2026 19:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQQl83BsDz3Zs9 for ; Tue, 03 Mar 2026 19:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772565972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zZ4rp2JBojvXB0j6kEAcwDBo1s5GWuKc4Eb8pRIWJ+4=; b=JpYyJoSuG1YETCdPzaYCNK8Tgo7OhBzvVeqF5zdt7WVCW0ZjslL8pa6BqBiZK2G54ZBW1Z DZxWtN0L8hh4CMF4UvL5MxciHvihgbSskXve8S5sZe1F2huVb1U4Vqne3N3ax1MQ1NOBdv ttr+BX4Md4TUyJeExCnhnrhHj26GiREIICtLl7IMfunxl7PiMtWyBUBpFKnPhofFbve5Nz mrZ6MZoZak4OCmHSp9ITOuLP2XHth8wveISQSaYnFaRmErohV8RdBPaEByvEh+YewEoQ8A IVl4JRs1+wHQpKcTzEwwqnfQk4A6b+4OxuR+zl92hFPxgXVZUkX4OgdUQ8Xvzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772565972; a=rsa-sha256; cv=none; b=Ouf/6XRMg2QJ56W7b772j94EzPFSbHzA6mGnKDdldil13fckCU0d9HnQ1VG4PvZguzq4kc cTAmsxr3clPYA8EtXZHNeBdUKwkQplegklFGXcy39kIdwBNNy1IZlfD0mSfFYYJJpvB73b NE1IrDZ8uFdTtJusrVon889rVrQaKVch/WCROUhKsh89Xu4aB93FJhwDzxoK/ZnIskY7W2 BK2VgA8O6F2XwGr8Ksc58mZrIyuHF6Uu7I6vM2j1FDAsrONvvwnkrRqvDjE+CxrUPNGVsM 2zyqpWO7E3C1ju8UPInBoaSsGOq2aeTs8OaRqjfuD46seZLld9tNN42CCQ0GvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772565972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zZ4rp2JBojvXB0j6kEAcwDBo1s5GWuKc4Eb8pRIWJ+4=; b=sMDjArri3CUMuzttRW9qtfAcfXDKU7E7ntA0EaYX/BRN2jy5HAyflDLLKfj1djFdMTDLwo swLcdzoti3RccDl12qo3HwUuQLd9ewx1L8/GEJNjp9WU44sJWTNUTSsDAmDUzCoMWKvwIj bB54+5g8AIA/kUIuuza4axNuI6QbcqjHw/lUX4yZ2JmBEjvPK5zqaXXW+sQQaTEA7DsNf5 H3y3agLthOR1gnBuT6mgkMCrYCCET/3ge4bKoAIjlwCM+FHh3TJg9zVkx7DqAHelcP0amK igGWpnxi5i+E11U4U+ggqRzohu2GM51vr00vjIWgHirtWIdf96kx7yT4TY7qMw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fQQl823cBz3D9 for ; Tue, 03 Mar 2026 19:26:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c359 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Mar 2026 19:26:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Siva Mahadevan Subject: git: f26cb4757eb7 - main - LinuxKPI: avoid -Werror=unused-value in sort() from BUILD_BUG_ON_ZERO() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f26cb4757eb74ceace39144933ae198ebf1b4f28 Auto-Submitted: auto-generated Date: Tue, 03 Mar 2026 19:26:07 +0000 Message-Id: <69a735cf.1c359.19b4d8ff@gitrepo.freebsd.org> The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=f26cb4757eb74ceace39144933ae198ebf1b4f28 commit f26cb4757eb74ceace39144933ae198ebf1b4f28 Author: Siva Mahadevan AuthorDate: 2026-03-03 19:09:35 +0000 Commit: Siva Mahadevan CommitDate: 2026-03-03 19:19:32 +0000 LinuxKPI: avoid -Werror=unused-value in sort() from BUILD_BUG_ON_ZERO() The BUILD_BUG_ON_ZERO() macro returns an (int)0 if it does not fail at build time. LinuxKPI sort() has it as a guard for an unsupported argument but ignores the return value. This leads to gcc complaining: /usr/src/sys/compat/linuxkpi/common/include/linux/build_bug.h:60:33: error: statement with no effect [-Werror=unused-value] 60 | #define BUILD_BUG_ON_ZERO(x) ((int)sizeof(struct { int:-((x) != 0); })) | ^ /usr/src/sys/compat/linuxkpi/common/include/linux/sort.h:37:9: note: in expansion of macro 'BUILD_BUG_ON_ZERO' 37 | BUILD_BUG_ON_ZERO(swap); \ | ^~~~~~~~~~~~~~~~~ /usr/src/sys/contrib/dev/rtw89/core.c:2575:9: note: in expansion of macro 'sort' 2575 | sort(drift, RTW89_BCN_TRACK_STAT_NR, sizeof(*drift), cmp_u16, NULL); Change to BUILD_BUG_ON() for the statement version. Reported by: CI Co-authored-by: bz Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D55634 --- sys/compat/linuxkpi/common/include/linux/sort.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/include/linux/sort.h b/sys/compat/linuxkpi/common/include/linux/sort.h index e6196d1f41c7..361b37c587c8 100644 --- a/sys/compat/linuxkpi/common/include/linux/sort.h +++ b/sys/compat/linuxkpi/common/include/linux/sort.h @@ -34,7 +34,7 @@ #include #define sort(base, num, size, cmp, swap) do { \ - BUILD_BUG_ON_ZERO(swap); \ + BUILD_BUG_ON(swap); \ qsort(base, num, size, cmp); \ } while (0)