From owner-cvs-all Tue Oct 9 10:29:48 2001 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id EF1EE37B405 for ; Tue, 9 Oct 2001 10:29:39 -0700 (PDT) Received: (qmail 80563 invoked from network); 9 Oct 2001 17:29:39 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 9 Oct 2001 17:29:39 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200110090934.f999Yo489935@hak.lan.Awfulhak.org> Date: Tue, 09 Oct 2001 10:29:06 -0700 (PDT) From: John Baldwin To: Brian Somers Subject: Re: cvs commit: src/sys/i386/isa pcaudio.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 09-Oct-01 Brian Somers wrote: >> jhb 2001/10/08 16:35:40 PDT >> >> Modified files: >> sys/i386/isa pcaudio.c >> Log: >> Don't attempt to initialize the pcaudio device on open. The attach >> routine >> already does the initialization (though it didn't set pca_initialized, so >> we always initialized twice) and since attach calls make_dev(), there's no >> way that pcaopen() can be called before pcaattach(). >> >> Revision Changes Path >> 1.63 +1 -7 src/sys/i386/isa/pcaudio.c > > Surely pcaopen() can be called before pcaattach() on a non-devfs > system (or does something else head the call off with an ENXIO) ? Wouldn't newbus do the pcaattach() before pcaopen() could possibly ever be called? Also, how else besides make_dev() does a device associate it's cdevsw with a major number? -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message