From owner-freebsd-pf@FreeBSD.ORG Thu Feb 26 09:24:46 2009 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F344106566B for ; Thu, 26 Feb 2009 09:24:46 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.freebsd.org (Postfix) with SMTP id F3E768FC08 for ; Thu, 26 Feb 2009 09:24:45 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: (qmail 8711 invoked by uid 0); 26 Feb 2009 08:58:05 -0000 Received: from 213.61.170.110 by www100.gmx.net with HTTP; Thu, 26 Feb 2009 09:58:04 +0100 (CET) Content-Type: text/plain; charset="iso-8859-1" Date: Thu, 26 Feb 2009 09:58:05 +0100 From: "Olli Hauer" In-Reply-To: <200902252050.02682.max@love2party.net> Message-ID: <20090226085805.27980@gmx.net> MIME-Version: 1.0 References: <9e20d71e0902250435y6e090fb0rc138233242fe7d60@mail.gmail.com> <200902251442.43794.max@love2party.net> <9e20d71e0902250610l62a42a99t5b9683aefb08c7cf@mail.gmail.com> <200902252050.02682.max@love2party.net> To: Max Laier , artis.caune@gmail.com X-Authenticated: #1956535 X-Flags: 0001 X-Mailer: WWW-Mail 6100 (Global Message Exchange) X-Priority: 3 X-Provags-ID: V01U2FsdGVkX1+c2J5cKxOcpN+Y/HgCKEwgoDx6INZfajrqHdlEy3 DXq2zVDP9tRPHeHLaZJbXUZWkhiE4DYrOiag== Content-Transfer-Encoding: 8bit X-GMX-UID: qmGQeNw5YmYBeoHteHc3BIFCWkZTQRRG X-FuHaFi: 0.46 Cc: samm@os2.kiev.ua, freebsd-pf@freebsd.org Subject: Re: openbsd spamd is leaking memory? X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 09:24:46 -0000 > On Wednesday 25 February 2009 15:10:04 Artis Caune wrote: > > 2009/2/25 Max Laier : > > > Hello Artis, > > > > > > looks like a valid catch to me. I'm CC'ing the upstream maintainer > (Bob, > > > that's you, right?) From a quick glance there is also a minor leak in > > > readsuffixlists in the goto bad case. > > Bob Beck has meanwhile committed the slightly more encompassing fix which > can > be obtained via webcvs: > http://www.openbsd.org/cgi- > bin/cvsweb/src/libexec/spamd/grey.c.diff?r1=1.45;r2=1.46 > > Alex, do you have time to roll a new release or would you prefer the patch > applied via the ports patch facilities? > > > I'm running spamd with this patch more than 2h and no leaks :) > > > > > > > > --- grey.c.orig 2008-12-07 23:12:52.000000000 +0200 > > +++ grey.c 2009-02-25 15:22:48.000000000 +0200 > > @@ -512,7 +512,8 @@ > > dbc->act = 0; > > dbc->dsiz = 0; > > SLIST_REMOVE_HEAD(&db_changes, entry); > > - > > + free(dbc); > > + dbc = NULL; > > } > > return(ret); > > } > > -- > /"\ Best regards, | mlaier@freebsd.org > \ / Max Laier | ICQ #67774661 > X http://pf4freebsd.love2party.net/ | mlaier@EFnet > / \ ASCII Ribbon Campaign | Against HTML Mail and News Hi Max/Alex, I prefer a patch in the ports since I updated the code to OpenBSD 4.3 and the sync protocol is not compatible with the old one. At the moment the code in svn is based on OpenBSD 4.3 + additional patches/features which i send nearly one year ago to tech@ but they where not committed (spamdb with sync feature for example). I will look if i found next week the time to finish the update to OpenBSD version 4.4 and then we can role out a new version. Regards, olli -- Computer Bild Tarifsieger! GMX FreeDSL - Telefonanschluss + DSL für nur 17,95 ¿/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a