From owner-cvs-all Wed May 5 19:31:13 1999 Delivered-To: cvs-all@freebsd.org Received: from stampede.cs.berkeley.edu (stampede.CS.Berkeley.EDU [128.32.45.124]) by hub.freebsd.org (Postfix) with ESMTP id A25D814CE3; Wed, 5 May 1999 19:31:09 -0700 (PDT) (envelope-from asami@cs.berkeley.edu) Received: from silvia.hip.berkeley.edu (sji-ca3-251.ix.netcom.com [209.109.233.251]) by stampede.cs.berkeley.edu (8.8.7/8.7.3) with ESMTP id TAA27331; Wed, 5 May 1999 19:31:38 -0700 (PDT) Received: (from asami@localhost) by silvia.hip.berkeley.edu (8.9.2/8.6.9) id TAA53326; Wed, 5 May 1999 19:29:18 -0700 (PDT) Date: Wed, 5 May 1999 19:29:18 -0700 (PDT) Message-Id: <199905060229.TAA53326@silvia.hip.berkeley.edu> X-Authentication-Warning: silvia.hip.berkeley.edu: asami set sender to asami@cs.berkeley.edu using -f To: fenner@research.att.com Cc: taoka@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org In-reply-to: <199905060224.WAA24140@windsor.research.att.com> (message from Bill Fenner on Wed, 5 May 1999 19:24:35 -0700) Subject: Re: cvs commit: ports/lang/jdk-doc Makefile ports/lang/jdk-doc/pkg MESSAGE.tmpl MESSAGE From: asami@freebsd.org (Satoshi - Ports Wraith - Asami) References: <199905051507.IAA01913@freefall.freebsd.org> <199905052125.OAA51502@silvia.hip.berkeley.edu> <199905060224.WAA24140@windsor.research.att.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk * From: Bill Fenner * >(rename pkg/MESSAGE.tmpl to pkg/MESSAGE) * * Isn't that misleading, especially if you don't happen to notice * * >PKGMESSAGE= ${WRKDIR}/MESSAGE * * in the Makefile? I'd think that making it files/MESSAGE.tmpl would make * it much more obvious what's going on. It probably doesn't matter either way for MESSAGE. But for things like PLIST, it's very much easier if one can do things like grep foobin */*/pkg/PLIST even if some of the pkg/PLIST's are only templates. :) That's why I recommend people to keep the standard names for stuff in ${PKGDIR}. Satoshi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message